1457405 - 0.2 - 0.35% installer size (linux64, osx-cross, windows2012-32, windows2012-64) regression on push be541e099174094c130b196a3a1510c121730f4e (Wed Apr 25 2018)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=be541e099174094c130b196a3a1510c121730f4e

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  0%  installer size linux64 pgo      61,986,484.00 -> 62,202,548.75
  0%  installer size osx-cross opt    66,262,310.75 -> 66,416,743.25
  0%  installer size windows2012-32 pgo 55,999,482.25 -> 56,109,786.17


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=12911

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Ionuț Goldan [:igoldan]]

:sotaro Multiple installer size alerts point to bug 1454878. There may be peculiarities with this alert, so please validate this tracking bug first.
If this is real, can you look into a fix or rather back it out, as you're going into PTO.

Comment 2

[Sotaro Ikeda [:sotaro]]

I am going to remove WrExternalLogHandler by bug 1457387 for unifying rust log. Then the size is going to become smaller again.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> I am going to remove WrExternalLogHandler by bug 1457387 for unifying rust
> log. Then the size is going to become smaller again.

Bug 1457387 landed last Friday. Did we see the expected win from it?

Comment 4

[Ionuț Goldan [:igoldan]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> (In reply to Sotaro Ikeda [:sotaro] from comment #2)
> > I am going to remove WrExternalLogHandler by bug 1457387 for unifying rust
> > log. Then the size is going to become smaller again.
> 
> Bug 1457387 landed last Friday. Did we see the expected win from it?

Yes, bug 1457387 resolved the regression.

== Change summary for alert #13108 (as of Tue, 08 May 2018 03:33:26 GMT) ==

Improvements:

  0%  installer size osx-cross opt      66,535,739.21 -> 66,362,369.58
  0%  installer size windows2012-32 pgo 56,168,295.71 -> 56,037,781.50
  0%  installer size linux64 pgo        62,274,852.62 -> 62,135,137.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=13108