Closed Bug 1457469 Opened 2 years ago Closed 2 years ago

Firefox's application menu on Windows lacks key annotation

Categories

(Firefox :: Menus, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: chutten, Assigned: Gijs)

References

Details

Attachments

(1 file)

bug 1441658 almost got us shortcut key annotation on the application menu on Windows, but the sea of nested #ifdefs in browser-menubar.inc hid in their murky depths semantics that still prevent the key annotation from being present on Windows.

We can probably be a bit clearer here while we're fixing this up to work on Windows. Apparently we even support #elifdef!

Area in question: https://dxr.mozilla.org/mozilla-central/rev/63a0e2f626febb98d87d2543955ab99a653654ff/browser/base/content/browser-menubar.inc#96-107
Summary: Firefox's application menu on Windows lacks windows-specific accesskey and label → Firefox's application menu on Windows lacks key annotation
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8971620 [details]
Bug 1457469 - fix display of shortcut key on Windows' File menu,

https://reviewboard.mozilla.org/r/240376/#review246194

So, in words:
On Windows: use windows-specific label and accesskey
On Mac: use mac-specific label and no accesskey
On Everyone Else: use generic label and accesskey
On All: use generic key and command

Seems legit.
Attachment #8971620 - Flags: review?(chutten) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/298e7cf3cef6
fix display of shortcut key on Windows' File menu, r=chutten
https://hg.mozilla.org/mozilla-central/rev/298e7cf3cef6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.