1457469 - Firefox's application menu on Windows lacks key annotation

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement, P3)

Description

[Chris H-C :chutten|PTO (back Jan 5)]

bug 1441658 almost got us shortcut key annotation on the application menu on Windows, but the sea of nested #ifdefs in browser-menubar.inc hid in their murky depths semantics that still prevent the key annotation from being present on Windows.

We can probably be a bit clearer here while we're fixing this up to work on Windows. Apparently we even support #elifdef!

Area in question: https://dxr.mozilla.org/mozilla-central/rev/63a0e2f626febb98d87d2543955ab99a653654ff/browser/base/content/browser-menubar.inc#96-107

Comment 1

[:Gijs (out until Jan 5th; he/him)]

Attachment: Bug 1457469 - fix display of shortcut key on Windows' File menu,

Review commit: https://reviewboard.mozilla.org/r/240376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240376/

Comment 2

[Chris H-C :chutten|PTO (back Jan 5)]

Comment on attachment 8971620 [details]
Bug 1457469 - fix display of shortcut key on Windows' File menu,

https://reviewboard.mozilla.org/r/240376/#review246194

So, in words:
On Windows: use windows-specific label and accesskey
On Mac: use mac-specific label and no accesskey
On Everyone Else: use generic label and accesskey
On All: use generic key and command

Seems legit.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/298e7cf3cef6
fix display of shortcut key on Windows' File menu, r=chutten

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/298e7cf3cef6