1457483 - check_vanilla_allocations.py cannot handle an LTO build

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Tom Ritter [:tjr]]

When building with Clang LTO, check_vanilla_allocations.py runs 'nm' on libjs_static.a, which fails, because nm cannot read that object file. We need to use the NM environment variable (which will point to llvm-nm)

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1457483 Retrieve nm from environment for check_vanilla_allocations.py

Review commit: https://reviewboard.mozilla.org/r/240430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240430/

Comment 2

[Tom Ritter [:tjr]]

Comment on attachment 8971664 [details]
Bug 1457483 Retrieve nm from environment for check_vanilla_allocations.py

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240430/diff/1-2/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8971664 [details]
Bug 1457483 Retrieve nm from environment for check_vanilla_allocations.py

https://reviewboard.mozilla.org/r/240430/#review246616

::: config/check_vanilla_allocations.py:80
(Diff revision 2)
>  
>      # Run |nm|.  Options:
>      # -u: show only undefined symbols
>      # -C: demangle symbol names
>      # -A: show an object filename for each undefined symbol
> -    cmd = ['nm', '-u', '-C', '-A', args.file]
> +    nm = buildconfig.substs.get('NM') or 'nm'

.get('NM', 'nm')

Comment 4

[Tom Ritter [:tjr]]

Comment on attachment 8971664 [details]
Bug 1457483 Retrieve nm from environment for check_vanilla_allocations.py

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240430/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23b5cf2c6824
Retrieve nm from environment for check_vanilla_allocations.py r=glandium

Comment 6

[Andreea Pavel [:apavel]]

Backed out for build bustages OSError: [Errno 13] Permission denied/ make[2]: *** [check-vanilla-allocations] Error 1

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=23b5cf2c6824961ffb77a4a1f9d5d0888d678281

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=178771924&repo=autoland&lineNumber=38705

Backout: https://hg.mozilla.org/integration/autoland/rev/71f9465fb8544b37a447efedf4cd8a220ee9b130

Comment 7

[Tom Ritter [:tjr]]

So " .get('NM', 'nm') " causes a build bust because NM is present and blank. I've changed it back to the prior version, which was " nm = buildconfig.substs.get('NM') or 'nm' "

Comment 8

[Tom Ritter [:tjr]]

Comment on attachment 8971664 [details]
Bug 1457483 Retrieve nm from environment for check_vanilla_allocations.py

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240430/diff/3-4/

Comment 9

[Mike Hommey [:glandium]]

fair enough.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4a56903882a
Retrieve nm from environment for check_vanilla_allocations.py r=glandium

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f4a56903882a