Closed Bug 1457517 Opened 7 years ago Closed 7 years ago

Update Debugger Frontend v46

Categories

(DevTools :: Debugger, enhancement, P3)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 4 obsolete files)

rel-46-5.patch
2.19 MB, patch
jdescottes
: review+
Details | Diff | Splinter Review
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Priority: -- → P3
early try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6abe84222f04c25208683001a9f2b54626f210f the patch is quite large, but it is just packages shuffling. No actual source code changed.
another try run, but also includes the devtools-reps work https://treeherder.mozilla.org/#/jobs?repo=try&revision=d750502bfc0158e8120baad6c0fe90fdd92512a3
Attached patch rel-46.patch (obsolete) — — Splinter Review
Attachment #8972561 - Flags: review?(jdescottes)
Attached patch rel-46-2.patch (obsolete) — — Splinter Review
Attachment #8972561 - Attachment is obsolete: true
Attachment #8972561 - Flags: review?(jdescottes)
Attachment #8972733 - Flags: review?(jdescottes)
Comment on attachment 8972733 [details] [diff] [review] rel-46-2.patch Review of attachment 8972733 [details] [diff] [review]: ----------------------------------------------------------------- devtools/client/debugger/new/test/mochitest/browser_dbg-stepping.js seems to have a high failure frequency on windows opt, we should probably look into this. Somehow can't push to try right now, so talos comparisons will have to wait. ::: devtools/client/debugger/new/test/mochitest/browser.ini @@ -210,5 @@ > [browser_dbg-sourcemaps-reloading.js] > [browser_dbg-sourcemaps2.js] > [browser_dbg-sourcemaps3.js] > [browser_dbg-sourcemaps-bogus.js] > -skip-if = os == 'linux' && !asan # bug 1447118 missing sync from bug 1447118
Attachment #8972733 - Flags: review?(jdescottes) → review+
Heads up also now missing sync from 1098374 -> https://github.com/devtools-html/debugger.html/pull/6234
Attached patch rel-46-3.patch (obsolete) — — Splinter Review
Attachment #8972733 - Attachment is obsolete: true
Attachment #8973764 - Flags: review?(jdescottes)
I dont think we'll need this, but here is a try run sans reps https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f543c504e65ebbe360ab73454265a46b1aaefaf I did this because i saw an error here - browser_webconsole_context_menu_store_as_global.js but i think that is an old test... that isnt relevant
Attached patch rel-46-4.patch (obsolete) — — Splinter Review
Attachment #8973764 - Attachment is obsolete: true
Attachment #8973764 - Flags: review?(jdescottes)
Attachment #8973772 - Flags: review?(jdescottes)
this should be basically identical, but better safe than sorry
Attached patch rel-46-5.patch — — Splinter Review
Attachment #8973772 - Attachment is obsolete: true
Attachment #8973772 - Flags: review?(jdescottes)
Attachment #8973845 - Flags: review?(jdescottes)
Attachment #8973845 - Flags: review?(jdescottes) → review+
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e31a502239b9 Update Debugger Frontend v46. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/e31a502239b9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
Depends on: 1496044
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: