1457671 - Can't scroll on channel of zhangyu.tv

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect, P3)

Description

[ganlu]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180327223059

Steps to reproduce:

1, Go to http://www.zhangyu.tv/channellist
2, Click any channel and get into it.



Actual results:

Can't scroll on the channel page with or without flash plugin enabled (Chrome/Chromium works well)


Expected results:

Scroll like any other pages.

Comment 1

[Daniel Bodea [:danibodea]]

I have reproduced this issue on the 3 main versions of Firefox (release - 59.0.3, beta - 60.0b16, nightly - 61.0a1) on a Windows10 x64.
Also, I can confirm that this issue does not occur in the case of using Chrome.

Comment 2

[Andrew McCreight [:mccr8]]

When I loaded this page, I got some errors in the browser console:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://area.zhangyu.tv/thank.php. (Reason: CORS request did not succeed).
Loading failed for the <script> with source “http://www.letv.com/bigdata/stats.js”. 3315140:1
Password fields present on an insecure (http://) page. This is a security risk that allows user login credentials to be stolen.[Learn More] 3315140
[Show/hide message details.] TypeError: e is undefined zlib-plug-play_7c397d6.js:1:5053
[Show/hide message details.] TypeError: e is undefined
zlib-plug-play_7c397d6.js:1:5053
[Show/hide message details.] TypeError: e is undefined zlib-plug-play_7c397d6.js:1:5053
[Show/hide message details.] TypeError: e is undefined
zlib-plug-play_7c397d6.js:1:5053
[Show/hide message details.] TypeError: e is undefined
zlib-plug-play_7c397d6.js:1:5053

When I try to scroll, the "e is undefined" message gets spammed a few times. "e" doesn't sound like a DOM API, so I'm going to move this to JS.

Comment 3

[Andrew McCreight [:mccr8]]

The error is happening here:
  e.preventDefault?e.preventDefault():e.returnValue=!1

So maybe it is a DOM issue...

Comment 4

[Andrew McCreight [:mccr8]]

Pretty printed and with a little more context it looks like the error is here:

    _inintEvent: function () {
      this.el.mousewheel($.proxy(function (a, b, c, d) {
        var e = e ? e : window.event;
        e.preventDefault ? e.preventDefault()  : e.returnValue = !1,
        this.el[0].scrollTop -= 20 * b,
        this._setBarPosition(),
        'function' == typeof this.callback && this.callback(this.el[0].scrollTop, this.el.height(), this.elc.height())
      }, this))
    },

Comment 5

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

(In reply to Andrew McCreight [:mccr8] from comment #4)
>       this.el.mousewheel($.proxy(function (a, b, c, d) {
>         var e = e ? e : window.event;

Looks like e is missing from the function arguments, so it falls back on window.event. Bug 218415 is waiting for the edge cases (Shadow DOM and event handlers modifying the target chain) to the specced.

Comment 6

[Mike Taylor [:miketaylr]]

I'm not able to reproduce the original issue -- 

ganlu, could you try to see if the bug is fixed in the latest Firefox Nightly?

https://www.mozilla.org/en-US/firefox/nightly/all/

thanks.

Comment 7

[ganlu]

I confirm that the Nightly (63.0a1 2018.08.05) works well now, thanks a lot.

Comment 8

[Daniel Bodea [:danibodea]]

I can also confirm:
The issue is not reproducible in Nightly (v63.0a1) anymore, but it is still reproducible in Beta (v62.0b14) and Release (v61.0.1) versions.

Thank you!

Comment 9

[Daniel Bodea [:danibodea]]

I have run a mozregression fix finder and these are my results:

The changeset that fixed our bug is: https://hg.mozilla.org/mozilla-central/rev/5e32f9974bd5
This changeset is a fix for bug 218415.

Mozregression results:
"
2018-08-06T15:50:32: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=5e32f9974bd52cc7ebd00c4d4fa256515b5ab951&full=1
2018-08-06T15:50:33: DEBUG : Found commit message:
Bug 218415 - Add window.event. r=smaug.

window.event is set on the wrong window when the target and the
callback are from different realms and the callback is an XPCOM
callback.

MozReview-Commit-ID: HXeUIicdMuT

2018-08-06T15:50:33: DEBUG : Did not find a branch, checking all integration branches
2018-08-06T15:50:33: INFO : The bisection is done.
2018-08-06T15:50:33: INFO : Stopped
"

Comment 10

[Gregory Pappas [:gregp]]

Reporter, are you still experiencing this issue?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:peterv, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 12

[Andrew McCreight [:mccr8]]

(In reply to ganlu from comment #7)

I confirm that the Nightly (63.0a1 2018.08.05) works well now, thanks a lot.