Closed Bug 1457810 Opened 2 years ago Closed 2 years ago

Move CalcComplexColor to ComputedStyle

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: kamidphish, Assigned: kamidphish)

References

Details

Attachments

(1 file)

Is review comments on Bug 1457353, :xidorn says `CalcComplexColor` should be moved from `nsStyleColor` into `ComputedStyle`.
(In reply to Dan Glastonbury (:kamidphish) | needinfo me from comment #0)
> Is review comments on Bug 1457353, :xidorn says `CalcComplexColor` should be
> moved from `nsStyleColor` into `ComputedStyle`.

In review ...
Priority: -- → P3
Assignee: nobody → dglastonbury
I'm going to take this as it will help with bug fixing SMIL animation fall out from work on bug 1457353.
It made more sense to me to move `CalcComplexColor` to `StyleComplexColor` instead of `ComputedStyle`.
Comment on attachment 8974590 [details]
Bug 1457810: Move CalcComplexColor to StyleComplexColor.

https://reviewboard.mozilla.org/r/242940/#review248774
Attachment #8974590 - Flags: review?(xidorn+moz) → review+
Pushed by dglastonbury@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91f19dc74d95
Move CalcComplexColor to StyleComplexColor. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/91f19dc74d95
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.