1457912 - [WordPress] The G+ pop-up window does not have a scroll bar

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: Not Scrollable.JPG

[Affected versions]:
-60.0b16 
-59.0.3

[Affected platforms]:
- Ubuntu 16.04 x64
- Windows 10 x64
- macOS 10.13

[Steps to reproduce]:
1.Go to this link:WordPress.com
2.Log in with an existing account.
3.Go to Sharing submenu from Configure.
4.Select to connect with G+.
5.Select Gmail account you wish to share with website.


[Expected result]:
-The confirmation prompt is displayed in a new windows and user can scroll down to confirm or reject form.

[Actual result]:
- It can be noticed that the new confirmation window is not scroll-able and multiple elements from the window cannot be viewed.

[Regression range]:
-This bug is a regression, I will return with the push log ASAP

[Additional notes]:
-This issue is not reproducible on Chrome 

-3 Warning messages are displayed inside the Web Console when reaching the affected window:

"Content Security Policy: Ignoring “'unsafe-inline'” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “https:” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “http:” within script-src: ‘strict-dynamic’ specified"

Comment 1

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

This bug seems to be an old regression 

Pushlog : https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9c5d494d05485aebf3fedf649abc0e7ae9d2dcf2&tochange=f14898695ee0dd14615914f3e1401f17df57fdd7

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

To reproduce this issue: run
> window.open("https://bugzilla.mozilla.org", "", "toolbar=0,width=780,height=500")
in web console (and allow the window to open).

The new window opened by this function call would be not scrollable. The key is "toolbar=0".

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

OK, this is a silly bug...

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1457912 - Don't disable scrollbars when the window feature isn't listed explicitly.

Review commit: https://reviewboard.mozilla.org/r/241914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241914/

Comment 5

[Code Review Bot [:reviewbot]]

Comment on attachment 8973569 [details]
Bug 1457912 - Don't disable scrollbars when the window feature isn't listed explicitly.

https://reviewboard.mozilla.org/r/241914/#review247762


Code analysis found 2 defects in this patch:
 - 2 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: toolkit/components/windowwatcher/test/browser_new_content_window_chromeflags.js:178
(Diff revision 1)
> + * @param win (nsIDOMWindow)
> + * @returns int
> + */
> +async function getContentChromeFlags(win) {
> +  let b = win.gBrowser.selectedBrowser;
> +  return await ContentTask.spawn(b, null, async function() {

Error: Redundant use of `await` on a return value. [eslint: no-return-await]

::: toolkit/components/windowwatcher/test/browser_new_content_window_chromeflags.js:300
(Diff revision 1)
> + * Opens a window with some chrome flags specified, which should not affect
> + * scrollbars flag which defaults to true when not disabled explicitly.
> + */
> +add_task(async function test_scrollbars_flag() {
> +  const SCRIPT = 'window.open("about:blank", "_blank", "toolbar=0");';
> +  const SCRIPT_PAGE = `data:text/html,<script>${SCRIPT}</script>`;

Error: 'script_page' is already declared in the upper scope. [eslint: no-shadow]

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8973569 [details]
Bug 1457912 - Don't disable scrollbars when the window feature isn't listed explicitly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241914/diff/1-2/

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8973569 [details]
Bug 1457912 - Don't disable scrollbars when the window feature isn't listed explicitly.

https://reviewboard.mozilla.org/r/241914/#review247852

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8876cbee5fa
Don't disable scrollbars when the window feature isn't listed explicitly. r=smaug

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f8876cbee5fa

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8973569 [details]
Bug 1457912 - Don't disable scrollbars when the window feature isn't listed explicitly.

Approval Request Comment
[Feature/Bug causing the regression]: very old regression
[User impact if declined]: may not see scrollbar in some window opened by script
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: just landed
[Needs manual test from QE? If yes, steps to reproduce]: window.open("https://bugzilla.mozilla.org", "", "toolbar=0,width=780,height=500")
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: shouldn't be risky.
[Why is the change risky/not risky?]: The old behavior was clearly undesired, but it wasn't reported for long, so presumably it isn't really widely used.
[String changes made/needed]:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8973569 [details]
Bug 1457912 - Don't disable scrollbars when the window feature isn't listed explicitly.

We're early in the cycle, so we should have time to catch any fallout from this. Approved for 61.0b4. Thanks for including a test too.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4c42b961f11f