1457927 - The most recent download is wrongly displayed in the last position, even if it was made after all "Bookmarks" and "Pocket" saves

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Notes]:
- If there are no "Bookmarks" or "Pocket" saves in the "Highlights" area, the most recent download is correctly displayed on the first position.

[Affected versions]:
- Nightly 61.0a1, Build ID 20180430100522

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a clean new Firefox profile.
- Have the "Highlights" section populated with "Bookmarks" and "Pocket" cards.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites.
2. Navigate to any website (eg. https://www.thinkbroadband.com/download) and download any file.
3. Open a new tab and observe the "Highlights" area.

[Expected result]:
- The most recent download is displayed first in the "Highlights" area.

[Actual results]:
- The most recent download is displayed last in the "Highlights" area.

[Additional Notes]:
- The issue is still reproducible after browser restart.
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4129

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e49c38afbca61fb018a6a3df520230822c461c09
Bug 1457927 - The most recent download is wrongly displayed in the last position

https://github.com/mozilla/activity-stream/commit/fa4feb135e24053e1825561f1fe6d418d6fa0015
Merge pull request #4129 from sarracini/bug_1457927

Bug 1457927 - The most recent download is wrongly displayed in the last position

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/2c8338ffc0c0

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Firefox: 61.0a1, Build ID 20180506220517

I have verified this issue and I can confirm that is no longer reproducible on Windows 10 x64, Mac 10.13 and Ubuntu 14.04 x64 with the latest Nightly build (61.0a1) installed. 
Now, the "Highlights" cards are displayed in a chronological order.