1457978 - Crash in mp4parse::read_stsd::h38af7ec9fe268a95

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-51fe9275-cde3-4384-a687-df2d20180429.
=============================================================

New crash spotted in b15: https://bit.ly/2HFhrAp. 15 crashes so far. Primarily affects Sony devices running API 26, and a few Samsung devices running API 24

Bugs since previous changeset: https://mzl.la/2vH8ipE
Backouts since previous changeset: https://mzl.la/2qN9p1p
Full Mercurial changelog: https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=FENNEC_60_0b13_RELEASE&tochange=f2ac3383fb97a55d11a876f17189613a852a0077&full=1

Top 10 frames of crashing thread:

0 libxul.so mp4parse::read_stsd::h38af7ec9fe268a95 src/libcore/result.rs:1172
1 libxul.so mp4parse::read_mdia::h1f706d487eb219b3 media/mp4parse-rust/mp4parse/src/lib.rs:923
2 libxul.so mp4parse::read_moov::h8f29d89238d9f31e media/mp4parse-rust/mp4parse/src/lib.rs:824
3 libxul.so mp4parse_capi::mp4parse_read media/mp4parse-rust/mp4parse/src/lib.rs:683
4 libxul.so mozilla::MP4Metadata::Parse dom/media/mp4/MP4Metadata.cpp:120
5 libxul.so mozilla::MP4Demuxer::Init dom/media/mp4/MP4Demuxer.cpp:162
6 libmozglue.so mozilla::detail::MutexImpl::unlock mozglue/misc/Mutex_posix.cpp:81
7 libxul.so nsAppShell::ScheduleNativeEventCallback widget/android/nsAppShell.h:191
8 libmozglue.so RedBlackTree<arena_chunk_map_t, ArenaAvailTreeTrait>::MoveRedLeft 
9 libmozglue.so RedBlackTree<arena_chunk_map_t, ArenaRunTreeTrait>::Remove memory/build/rb.h:521

=============================================================

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Bug 1451681 looks like the only MP4-related change in that range that I can see. No comment on whether it's plausibly-related or not, though.

Comment 2

[Jean-Yves Avenard [:jya]]

Yes I had a look at that one, but the crash test is unrelated to that. What we modified I'm that bug is only called long after the rust demuxer has been called. I'd be more concerned that it only affects Android. Was the rust compiler change recently?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Certainly not on Beta.

Comment 4

[Marcia Knous [:marcia]]

So far in early b17 returns there are no crashes showing up.

Comment 5

[Mike Taylor [:miketaylr]]

This seems to not exist anymore. Yay.