Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Blocks 2 bugs)

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
font-style:italic should use an italic face if available, or set the 'ital' variation to 1.0 if present; or use a 14° synthetic-slant as fallback.

font-style:oblique should use a face declared as oblique, or set the 'slnt' axis to the specified value (default 14); or use a synthetic slant of the specified angle.

(In both cases, synthetic slant is only used if font-synthesis includes the 'style' value.)
(Assignee)

Updated

a year ago
Blocks: css-fonts-4
No longer blocks: 1435692
(Assignee)

Comment 1

a year ago
This will build on top of the font-weight handling from bug 1449605.
Blocks: 1449605
(Assignee)

Updated

a year ago
No longer blocks: 1449605
Depends on: 1449605
(Assignee)

Updated

a year ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8972139 [details] [diff] [review]
Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling

Review of attachment 8972139 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxFontEntry.cpp
@@ +1133,5 @@
> +    if (!mCheckedForVariationAxes) {
> +        CheckForVariationAxes();
> +    }
> +
> +    return (mRangeFlags & RangeFlags::eItalicVariation) ==

You don't need the ==. If you're worried about this being misread you could write it as the following which I think is a bit more readable:

  return bool(mRangeFlags & RangeFlags::eItalicVariation);

::: gfx/thebes/gfxFontEntry.h
@@ +662,5 @@
> +{
> +    return SlantStyle().Max().IsItalic() ||
> +           ((mRangeFlags & RangeFlags::eAutoSlantStyle) ==
> +               RangeFlags::eAutoSlantStyle &&
> +            HasItalicVariation());

Again, I'd prefer not to have the == personally.
Attachment #8972139 - Flags: review?(jwatt) → review+
(Assignee)

Updated

a year ago
Priority: -- → P2
(Assignee)

Updated

a year ago
Blocks: 1460259

Comment 4

a year ago
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18cf597d218b
Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling. r=jwatt

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/18cf597d218b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.