1458060 - Implement ability to pin/unpin a selection of tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Abdoulaye O. LY]

When a group of tabs are selected:

1. Right-clicking on any tab in the selection should:
 1a. Provide a context menu option of "Pin selected tabs".
 1b. The "Pin tab" option will be hidden.

Comment 1

[YUKI "Piro" Hiroshi]

Does this feature affect to the WebExtensions API: browser.tabs.update(id, { pinned: true/false })? When one of multiselected tab is updated, all multiselected tabs should be pinned also?

Comment 2

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

browser.tabs.update(id, {highlighted: true}) would be used to highlight the tab. See bug 1465170.

Comment 3

[Abdoulaye O. LY]

Attachment: Bug 1458060 - Implement ability to pin/unpin a selection of tabs.

Review commit: https://reviewboard.mozilla.org/r/252664/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252664/

Comment 4

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8987658 [details]
Bug 1458060 - Implement ability to pin/unpin a selection of tabs.

https://reviewboard.mozilla.org/r/252664/#review259744

::: browser/base/content/tabbrowser.js:3685
(Diff revision 1)
> -  get multiSelectedTabsCount() {
> +  get multiSelectedTabs() {
>      return ChromeUtils.nondeterministicGetWeakSetKeys(this._multiSelectedTabsSet)
> -      .filter(tab => tab.isConnected && !tab.closing)
> +                      .filter(tab => tab.isConnected && !tab.closing);

See bug 1465170 which is adding this same function, although with a different name (selectedTabs). Can you rebase your changes on top of that patch?

::: browser/locales/en-US/chrome/browser/browser.dtd:41
(Diff revision 1)
>  <!ENTITY  closeOtherTabs.accesskey           "o">
> +
>  <!ENTITY  closeSelectedTabs.label            "Close Selected Tabs">
>  <!ENTITY  closeSelectedTabs.accesskey        "S">
> +<!ENTITY  pinSelectedTabs.label              "Pin Tabs">
> +<!-- <!ENTITY  pinSelectedTabs.accesskey          "i"> All letters are  already used -->

You can use "P" for this, and add a note that pinSelectedTabs and pinTab will never be visible at the same time.

::: browser/locales/en-US/chrome/browser/browser.dtd:43
(Diff revision 1)
>  <!ENTITY  closeSelectedTabs.label            "Close Selected Tabs">
>  <!ENTITY  closeSelectedTabs.accesskey        "S">
> +<!ENTITY  pinSelectedTabs.label              "Pin Tabs">
> +<!-- <!ENTITY  pinSelectedTabs.accesskey          "i"> All letters are  already used -->
> +<!ENTITY  unpinSelectedTabs.label            "Unpin Tabs">
> +<!-- <!ENTITY  unpinSelectedTabs.accesskey        "b"> All letters are  already used -->

You can use "b" for this, and make a note that unpinSelectedTabs and unpinTab will never be visible at the same time.

Comment 5

[Abdoulaye O. LY]

Comment on attachment 8987658 [details]
Bug 1458060 - Implement ability to pin/unpin a selection of tabs.

https://reviewboard.mozilla.org/r/252664/#review259744

> See bug 1465170 which is adding this same function, although with a different name (selectedTabs). Can you rebase your changes on top of that patch?

Yes, great!

Comment 6

[Abdoulaye O. LY]

Comment on attachment 8987658 [details]
Bug 1458060 - Implement ability to pin/unpin a selection of tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252664/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ca7657db998
Implement ability to pin/unpin a selection of tabs. r=jaws

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8ca7657db998

Comment 9

[Vlad Lucaci, QA (:vlucaci)]

Verified fixed that this implementation is present on the latest Nightly Nightly 65.0a1(2018-11-22)and the latest Beta 64.0b11 as well .