Closed Bug 1458060 Opened 3 years ago Closed 2 years ago

Implement ability to pin/unpin a selection of tabs

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed
firefox64 --- verified
firefox65 --- verified

People

(Reporter: ablayelyfondou, Assigned: ablayelyfondou, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: feature)

Attachments

(1 file)

When a group of tabs are selected:

1. Right-clicking on any tab in the selection should:
 1a. Provide a context menu option of "Pin selected tabs".
 1b. The "Pin tab" option will be hidden.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Does this feature affect to the WebExtensions API: browser.tabs.update(id, { pinned: true/false })? When one of multiselected tab is updated, all multiselected tabs should be pinned also?
browser.tabs.update(id, {highlighted: true}) would be used to highlight the tab. See bug 1465170.
Summary: Implement ability to pin a selection of tabs → Implement ability to pin/unpin a selection of tabs
Assignee: nobody → ablayelyfondou
Status: NEW → ASSIGNED
Comment on attachment 8987658 [details]
Bug 1458060 - Implement ability to pin/unpin a selection of tabs.

https://reviewboard.mozilla.org/r/252664/#review259744

::: browser/base/content/tabbrowser.js:3685
(Diff revision 1)
> -  get multiSelectedTabsCount() {
> +  get multiSelectedTabs() {
>      return ChromeUtils.nondeterministicGetWeakSetKeys(this._multiSelectedTabsSet)
> -      .filter(tab => tab.isConnected && !tab.closing)
> +                      .filter(tab => tab.isConnected && !tab.closing);

See bug 1465170 which is adding this same function, although with a different name (selectedTabs). Can you rebase your changes on top of that patch?

::: browser/locales/en-US/chrome/browser/browser.dtd:41
(Diff revision 1)
>  <!ENTITY  closeOtherTabs.accesskey           "o">
> +
>  <!ENTITY  closeSelectedTabs.label            "Close Selected Tabs">
>  <!ENTITY  closeSelectedTabs.accesskey        "S">
> +<!ENTITY  pinSelectedTabs.label              "Pin Tabs">
> +<!-- <!ENTITY  pinSelectedTabs.accesskey          "i"> All letters are  already used -->

You can use "P" for this, and add a note that pinSelectedTabs and pinTab will never be visible at the same time.

::: browser/locales/en-US/chrome/browser/browser.dtd:43
(Diff revision 1)
>  <!ENTITY  closeSelectedTabs.label            "Close Selected Tabs">
>  <!ENTITY  closeSelectedTabs.accesskey        "S">
> +<!ENTITY  pinSelectedTabs.label              "Pin Tabs">
> +<!-- <!ENTITY  pinSelectedTabs.accesskey          "i"> All letters are  already used -->
> +<!ENTITY  unpinSelectedTabs.label            "Unpin Tabs">
> +<!-- <!ENTITY  unpinSelectedTabs.accesskey        "b"> All letters are  already used -->

You can use "b" for this, and make a note that unpinSelectedTabs and unpinTab will never be visible at the same time.
Attachment #8987658 - Flags: review?(jaws) → review+
Comment on attachment 8987658 [details]
Bug 1458060 - Implement ability to pin/unpin a selection of tabs.

https://reviewboard.mozilla.org/r/252664/#review259744

> See bug 1465170 which is adding this same function, although with a different name (selectedTabs). Can you rebase your changes on top of that patch?

Yes, great!
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ca7657db998
Implement ability to pin/unpin a selection of tabs. r=jaws
https://hg.mozilla.org/mozilla-central/rev/8ca7657db998
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Verified fixed that this implementation is present on the latest Nightly Nightly 65.0a1(2018-11-22)and the latest Beta 64.0b11 as well .
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.