1458061 - Implement ability to reload a selection of tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Abdoulaye O. LY]

When a group of tabs are selected, right-clicking on any tab in the selection should:
 1. Provide a context menu option of "Reload selected tabs".
 1. The "Reload tab" option will be hidden.

Comment 1

[Abdoulaye O. LY]

Sorry the second option listed above should be numbered 2.

Comment 2

[YUKI "Piro" Hiroshi]

Does this feature affect to the WebExtensions API: browser.tabs.reload(id)? When one of multiselected tab is updated, all multiselected tabs should be reloaded also?

Comment 3

[Geoffrey De Belie (Smile4ever)]

(In reply to YUKI "Piro" Hiroshi from comment #2)
> Does this feature affect to the WebExtensions API: browser.tabs.reload(id)?
> When one of multiselected tab is updated, all multiselected tabs should be
> reloaded also?

I don't think we want that, instead I would suggest the following:
browser.tabs.query({currentWindow: true, highlighted: true}).then((tabs) => {
  for(tab of tabs){
    browser.tabs.reload(tab.id);
  }
}, null);

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Yes, I agree with Geoffrey.

Comment 5

[Abdoulaye O. LY]

Attachment: Bug 1458061 - Implement ability to reload a selection of tabs.

Review commit: https://reviewboard.mozilla.org/r/253882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253882/

Comment 6

[Abdoulaye O. LY]

Attachment: Bug 1458061 - Implement ability to reload a selection of tabs.

Review commit: https://reviewboard.mozilla.org/r/253882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253882/

Comment 7

[:Gijs (he/him)]

Mozreview has gotten confused here and I can't submit a review (I get an http 500 error). :-(

Here are my review comments anyway:

Overall: Somehow mozreview has gotten confused here and there's no summary listed, and it's been put on bugzilla twice. Both bugzilla reviews point to the same mozreview changeset so I assume one review is enough. I hope landing it works, otherwise let me know and I can land it on inbound.

Anyway, this looks good with these minor points below addressed. Thank you!


Top of the new test file:
Nit: please include a public domain license header on the test file.


About the access key in the .dtd:
Given *either* Reload Tab *or* Reload Selected Tabs is visible, I assume you can use the same access key here (ie "R").

Also, just like with `Unpin Tab and Unpin Selected Tabs`, it's probably worth adding a localization comment so that localizers are aware of this.

Comment 8

[:Gijs (he/him)]

Comment on attachment 8989093 [details]
Bug 1458061 - Implement ability to reload a selection of tabs.

r=me with the comments in my previous comment on the bug, though mozreview seems to be in a bad state wrt this commit. You may want to use `hg export` and attach the cset with the comments addressed on the bug, then set checkin-needed and obsolete the mozreview attachments.

Comment 9

[Abdoulaye O. LY]

(In reply to :Gijs (he/him) from comment #7) 
> Top of the new test file:
> Nit: please include a public domain license header on the test file.

Yes, I did with the first patch submitted and this is what I got from Jared (comment https://bugzilla.mozilla.org/show_bug.cgi?id=1458010#c8): 

"Test code is normally licensed under Public Domain. You can remove the license header here, and by default the test will fall under Public Domain based on the Licensing of Mozilla Code section of https://www.mozilla.org/en-US/MPL/license-policy/".

Since then I don't add licence header on test files. What do you think?

Comment 10

[Abdoulaye O. LY]

Comment on attachment 8989093 [details]
Bug 1458061 - Implement ability to reload a selection of tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253882/diff/1-2/

Comment 11

[Abdoulaye O. LY]

Attachment: Implement ability to reload a selection of tabs

MozReview-Commit-ID: CyJLk7pxGRr

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1050ddd2bad8
Implement ability to reload a selection of tabs. r=Gijs

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1050ddd2bad8

Comment 14

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1050ddd2bad8

Comment 15

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Verified fixed that this implementation is present on the latest Nightly Nightly 65.0a1(2018-11-22)and the latest Beta 64.0b11 as well .