1458154 - Add a tunable for the idle time collection nursery threshold

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Paul Bone [:pbone]]

Make Nursery::kIdleTimeCollectionThreshold a GC Scheduling tunable.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1458154 - Add a tunable for idle nursery collection

This is a patch I've split off from Bug 1407143 since it's now a bit more general.  I will then use it in that bug to tune nursery collection at the beginning of a slice.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8972244 [details] [diff] [review]
Bug 1458154 - Add a tunable for idle nursery collection

Review of attachment 8972244 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for doing this.

::: js/src/gc/Nursery.cpp
@@ +679,5 @@
> +bool
> +js::Nursery::needIdleTimeCollection() const {
> +    uint32_t threshold =
> +        runtime()->gc.tunables.nurseryFreeThresholdForIdleCollection();
> +    return minorGCRequested() || (freeSpace() < threshold);

nit: parentheses unnecessary around the free space condition.

::: js/src/gc/Scheduling.h
@@ +435,5 @@
> +     * Attempt to run a minor GC in the idle time if the free space falls
> +     * below this threshold.
> +     */
> +    UnprotectedData<uint32_t> nurseryFreeThresholdForIdleCollection_;
> +  

nit: please remove trailing whitespace.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b9cbc054960
Add a tunable for idle nursery collection r=jonco

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3b9cbc054960