Closed Bug 1458198 Opened 2 years ago Closed 2 years ago

Assert the frontend reports an exception when it fails to compile a script

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Follow-up to bug 1457475 comment 4 and comment 5.

This adds AutoAssertReportedException and uses it to check there's a pending exception (on the cx if main thread or on the ParseTask if off-thread) in all the frontend::Compile* entry points.
Attachment #8972270 - Flags: review?(jorendorff)
Comment on attachment 8972270 [details] [diff] [review]
Patch

Review of attachment 8972270 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thank you.
Attachment #8972270 - Flags: review?(jorendorff) → review+
Priority: -- → P1
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce42829bf948
Assert the frontend reported an exception if it fails to compile a script. r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/ce42829bf948
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1459454
You need to log in before you can comment on or make changes to this bug.