Closed
Bug 1458259
Opened 6 years ago
Closed 6 years ago
Remove invalid assertion in UpdateZoomConstraints
Categories
(Core :: Panning and Zooming, enhancement, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
Fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1449982#c75 - the assertion in UpdateZoomConstraints is no longer accurate, since with GPU process and async-scene-building enabled in WR, it can get called on the compositor thread in the GPU process, which is not the updater thread.
Assignee | ||
Comment 1•6 years ago
|
||
Bas was hitting this assertion failure in his local debug windows build with WR enabled.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bugmail
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: [gfx-noted]
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8972347 [details] Bug 1458259 - Remove assertion that is no longer valid. https://reviewboard.mozilla.org/r/240972/#review247028
Attachment #8972347 -
Flags: review?(botond) → review+
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8972347 [details] Bug 1458259 - Remove assertion that is no longer valid. https://reviewboard.mozilla.org/r/240972/#review247034 ::: gfx/layers/apz/src/APZCTreeManager.cpp:1989 (Diff revision 1) > { > if (!GetUpdater()->IsUpdaterThread()) { > // This can happen if we're in the UI process and got a call directly from > - // nsBaseWidget (as opposed to over PAPZCTreeManager). We want this function > - // to run on the updater thread, so bounce it over. > - MOZ_ASSERT(XRE_IsParentProcess()); > + // nsBaseWidget (as opposed to over PAPZCTreeManager). It can also happen > + // in the GPU process if that is enabled, since the call will go over > + // PAPZCTreeManager and arrive on the compositor thread in the GPU process. If the GPU process is disabled but WR + async scene building are enabled, this can also happen on the UI process compositor thread receiving a message over PAPZCTreeManager, can't it? (That is, the removal of the assertion is fine, but the comment is still misleading.)
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Botond Ballo [:botond] from comment #4) > If the GPU process is disabled but WR + async scene building are enabled, > this can also happen on the UI process compositor thread receiving a message > over PAPZCTreeManager, can't it? Yup, you're right. I'll update the comment.
Comment hidden (mozreview-request) |
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38b1ed4d8bd2 Remove assertion that is no longer valid. r=botond
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/38b1ed4d8bd2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•