145827 - in PPEmbed window.focus and window.blur not functioning correctly

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[dsirnapalli]

-- Test case attached.

Comment 1

[dsirnapalli]

Attachment: Small window used by the test case

Comment 2

[dsirnapalli]

Attachment: Test case to reproduce the bug

Comment 3

[dsirnapalli]

-- Please refer to bugzilla bug
http://bugzilla.mozilla.org/show_bug.cgi?id=57841
It says this bug is fixed on mozilla.

Comment 4

[Conrad Carlen (not reading bugmail)]

Attachment: patch

Implements focus and blur.

Comment 5

[Conrad Carlen (not reading bugmail)]

Looking for r/sr.

Comment 6

[Conrad Carlen (not reading bugmail)]

Adam, this is the PPEmbed patch like the mfcEmbed one you checked in for bug
149307. Can you r= this one?

Comment 7

[Adam Lock]

Comment on attachment 88255 [details] [diff] [review]
patch

r=adamlock

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 88255 [details] [diff] [review]
patch

sr=sfraser

Comment 9

[Conrad Carlen (not reading bugmail)]

Fixed. Verify using test case in
http://bugzilla.mozilla.org/attachment.cgi?id=84352&action=view. Then, it should
go onto the branch.

Comment 10

[dsirnapalli]

-- Verified in today's trunk build(2002-07-01-03-trunk). works fine. marking the
bug as verified.

Comment 11

[Conrad Carlen (not reading bugmail)]

Thanks for the verification. With that, it should go on the 1.0.1 branch.
nominating topembed.

Comment 12

[chris hofmann]

Comment on attachment 88255 [details] [diff] [review]
patch

a=chofmann for 1.0.1 add fixed1.0.1 after checking in.

Comment 13

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 14

[Conrad Carlen (not reading bugmail)]

Checked into 1.0.1 branch.

Comment 15

[dsirnapalli]

-Verified it on today branch build.(2002-07-09-05-1.0/Mac-Embed.sit.bin). Works
fine.