Closed Bug 1458290 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 10738 - Move AudioParam tests to WPT

Categories

(Core :: Web Audio, enhancement, P4)

Product:
Core
Component:
Web Audio
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 10738 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10738
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:
>  Move AudioParam tests to WPT
>  
>  Move many but not all WebAudio AudioParam tests to WPT.
>  
>  The criteria was whether Firefox passed the tests or, if not, the
>  errors are actually bugs in Firefox.  Most of the failures are because
>  Firefox threw the wrong type of error.  We also skipped over most of
>  the tests that use offline.suspend().
>  
>  Bug: 745778
>  Change-Id: If4755089938ddf1b9825faa3392d1d10e3b9293f
>  Reviewed-on: https://chromium-review.googlesource.com/1036456
>  WPT-Export-Revision: 4d6c94ca402358bb91e520329218c5a6e7f9728e
Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 12 tests and 626 subtests
OK     : 11
PASS   : 587
FAIL   : 39
ERROR  : 1

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audioparam-interface/audioparam-exceptional-values.html
    # AUDIT TASK RUNNER FINISHED: 2 out of 6 tasks were failed.: FAIL
    < [special cases 1] 8 out of 8 assertions were failed.: FAIL
    < [special cases 2] 3 out of 3 assertions were failed.: FAIL
    X gain.gain.exponentialRampToValueAtTime(-1e-100,1) threw "SyntaxError" instead of RangeError.: FAIL
    X gain.gain.exponentialRampToValueAtTime(0,1) threw "SyntaxError" instead of RangeError.: FAIL
    X gain.gain.exponentialRampToValueAtTime(1,-1) threw "NotSupportedError" instead of RangeError.: FAIL
    X gain.gain.exponentialRampToValueAtTime(1e-100,1) threw "SyntaxError" instead of RangeError.: FAIL
    X gain.gain.linearRampToValueAtTime(1,-1) threw "NotSupportedError" instead of RangeError.: FAIL
    X gain.gain.setTargetAtTime(1,-1,1) threw "NotSupportedError" instead of RangeError.: FAIL
    X gain.gain.setTargetAtTime(1,1,-1) threw "NotSupportedError" instead of RangeError.: FAIL
    X gain.gain.setValueAtTime(1,-1) threw "NotSupportedError" instead of RangeError.: FAIL
    X gain.gain.setValueCurveAtTime([0,0,0],-1,1) threw "NotSupportedError" instead of RangeError.: FAIL
    X gain.gain.setValueCurveAtTime([0,0,0],1,-1) did not throw an exception.: FAIL
    X gain.gain.setValueCurveAtTime(curve, 1, 0) did not throw an exception.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/audioparam-large-endtime.html: ERROR
/webaudio/the-audio-api/the-audioparam-interface/audioparam-method-chaining.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 3 tasks were failed.: FAIL
    < [invalid-operation] 3 out of 4 assertions were failed.: FAIL
    X Calling exponentialRampToValueAtTime() with a zero target value threw "SyntaxError" instead of RangeError.: FAIL
    X Calling setValueAtTime() with a negative end time threw "NotSupportedError" instead of RangeError.: FAIL
    X The gain value of the second gain node is not equal to 0.5. Got 1.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html
    # AUDIT TASK RUNNER FINISHED: 3 out of 5 tasks were failed.: FAIL
    < [automations] 5 out of 13 assertions were failed.: FAIL
    < [curve lengths] 2 out of 3 assertions were failed.: FAIL
    < [setValueCurve] 4 out of 6 assertions were failed.: FAIL
    X exponentialRampToValueAtTime(1, 0.018750000000000003) threw "SyntaxError" instead of NotSupportedError.: FAIL
    X linearRampToValueAtTime(1, 0.018750000000000003) threw "SyntaxError" instead of NotSupportedError.: FAIL
    X setTargetAtTime(1, 0.018750000000000003, 1) threw "SyntaxError" instead of NotSupportedError.: FAIL
    X setValueAtTime(1, 0.018750000000000003) threw "SyntaxError" instead of NotSupportedError.: FAIL
    X setValueCurveAtTime([1], 0, 0.01) did not throw an exception.: FAIL
    X setValueCurveAtTime([], 0, 0.01) threw "SyntaxError" instead of InvalidStateError.: FAIL
    X setValueCurveAtTime(curve, 0.00625, 0.01) threw "SyntaxError" instead of NotSupportedError.: FAIL
    X setValueCurveAtTime(curve, 0.018750000000000003, 0.01) threw "SyntaxError" instead of NotSupportedError.: FAIL
    X setValueCurveAtTime(curve, 0.03125, 0.01) threw "SyntaxError" instead of NotSupportedError.: FAIL
    X setValueCurveAtTime(curve, 0.031415926535897934, 0.01) threw "SyntaxError" instead of NotSupportedError.: FAIL
    X setValueCurveAtTime(curve, 0.043750000000000004, 0.01) threw "SyntaxError" instead of NotSupportedError.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/event-insertion.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 4 tasks were failed.: FAIL
    < [Insert same event at same time] 3 out of 12 assertions were failed.: FAIL
    X Output at frame 512 (time 0.03125) is not equal to 4. Got 3.: FAIL
    X setValueCurveAtTime([3,4], 0.0234375, 0.0078125) incorrectly threw TypeError: "Argument 1 of AudioParam.setValueCurveAtTime does not implement interface Float32Array.".: FAIL
    X setValueCurveAtTime([98,99], 0.0234375, 0.0078125) incorrectly threw TypeError: "Argument 1 of AudioParam.setValueCurveAtTime does not implement interface Float32Array.".: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e3884bddab5
[wpt PR 10738] - Move AudioParam tests to WPT, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/875d698e6ab1
[wpt PR 10738] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8e3884bddab5
https://hg.mozilla.org/mozilla-central/rev/875d698e6ab1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.