layout/style/test/test_dont_use_document_colors.html fails on Windows ASan builds

RESOLVED FIXED in mozilla65

Status

()

defect
P3
normal
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: dmajor, Assigned: jfkthame)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

a year ago
I can't reproduce this locally, but it's consistent on Try: https://queue.taskcluster.net/v1/task/c71gDT7LSpWZwQlMKo_0Aw/runs/0/artifacts/public/logs/live_backing.log

Given that ASan builds have extra slowness, maybe it's a timing issue? Perhaps the effects of the pref change don't propagate through the system in time for the code that reads it? I'm just guessing.

May be related to bug 1458364, which like this bug also flips a pref and looks for a computed style change.

I intend to land a change disabling this test on Windows ASan builds, and mark this bug as leave-open.
Reporter

Updated

a year ago
Blocks: 1347793
Reporter

Comment 2

a year ago
I tried increasing the timeout but it didn't seem to help.

Comment 3

a year ago
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7311a5f318d3
Skip test_dont_use_document_colors.html on Windows ASan. DONTBUILD
Reporter

Updated

a year ago
Keywords: leave-open
Priority: -- → P3
Assignee

Comment 5

6 months ago
Tryserver indicates that this no longer fails, so we can re-enable the test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0453f071f396c0bbe4e4e1b6dcbfd441a47c6f79. So I'm going to push this with r=dmajor that was pre-emptively given in bug 1458364 comment 9.
Assignee

Updated

6 months ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED

Comment 6

6 months ago
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a17e7caad447
Re-enable test_dont_use_document_colors.html on Windows/ASAN, as it no longer seems to fail there. r=dmajor
Reporter

Updated

5 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.