1458365 - layout/style/test/test_dont_use_document_colors.html fails on Windows ASan builds

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[(Away)]

I can't reproduce this locally, but it's consistent on Try: https://queue.taskcluster.net/v1/task/c71gDT7LSpWZwQlMKo_0Aw/runs/0/artifacts/public/logs/live_backing.log

Given that ASan builds have extra slowness, maybe it's a timing issue? Perhaps the effects of the pref change don't propagate through the system in time for the code that reads it? I'm just guessing.

May be related to bug 1458364, which like this bug also flips a pref and looks for a computed style change.

I intend to land a change disabling this test on Windows ASan builds, and mark this bug as leave-open.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Sounds very likely a timing issue: https://searchfox.org/mozilla-central/rev/795575287259a370d00518098472eaa5b362bfa7/layout/style/test/test_dont_use_document_colors.html#52-57

Comment 2

[(Away)]

I tried increasing the timeout but it didn't seem to help.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7311a5f318d3
Skip test_dont_use_document_colors.html on Windows ASan. DONTBUILD

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7311a5f318d3

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Re-enable test_dont_use_document_colors.html on Windows/ASAN, as it no longer seems to fail there

Tryserver indicates that this no longer fails, so we can re-enable the test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0453f071f396c0bbe4e4e1b6dcbfd441a47c6f79. So I'm going to push this with r=dmajor that was pre-emptively given in bug 1458364 comment 9.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a17e7caad447
Re-enable test_dont_use_document_colors.html on Windows/ASAN, as it no longer seems to fail there. r=dmajor

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/a17e7caad447