Closed
Bug 1458414
Opened 6 years ago
Closed 6 years ago
Call DiscardCompositorAnimations() after BuildWebRenderCommands()
Categories
(Core :: Graphics: WebRender, enhancement, P2)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(3 files)
Now bug 1457448 has landed, we can discard finished animation as soon as possible (on the same transaction). https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d0f4279f8db851fe495f3184fe6dbeaf461a01b I did forget enable test_animations_omta.html in above try. Here is another try to run test_animations_omta.html https://treeherder.mozilla.org/#/jobs?repo=try&revision=69b7fb524b1bc7083b325b26778a945c17901b96
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
This is a WebRender bug actually.
Component: Graphics → Graphics: WebRender
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8972486 [details] Bug 1458414 - Call DiscardCompositorAnimations() after BuildWebRenderCommands(). https://reviewboard.mozilla.org/r/241078/#review246954
Attachment #8972486 -
Flags: review?(bugmail) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8972487 [details] Bug 1458414 - Enable animation tests on WebRender. https://reviewboard.mozilla.org/r/241080/#review246956 \o/
Attachment #8972487 -
Flags: review?(bugmail) → review+
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8972488 [details] Bug 1458414 - Enable test_animation_omta.html on WebRender. https://reviewboard.mozilla.org/r/241082/#review246958
Attachment #8972488 -
Flags: review?(bugmail) → review+
Comment 8•6 years ago
|
||
I went ahead and landed this since the patches look good and try push was clean, and that way we reduce the timezone-induced latency on all this work :)
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2cbfb9dd35e Call DiscardCompositorAnimations() after BuildWebRenderCommands(). r=kats https://hg.mozilla.org/integration/autoland/rev/af61a9b83a65 Enable animation tests on WebRender. r=kats https://hg.mozilla.org/integration/autoland/rev/0f766b153ebf Enable test_animation_omta.html on WebRender. r=kats
Updated•6 years ago
|
Blocks: stage-wr-trains
Priority: -- → P2
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b2cbfb9dd35e https://hg.mozilla.org/mozilla-central/rev/af61a9b83a65 https://hg.mozilla.org/mozilla-central/rev/0f766b153ebf
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee | ||
Comment 11•6 years ago
|
||
Thanks for landing, kats!
You need to log in
before you can comment on or make changes to this bug.
Description
•