Closed
Bug 1458466
Opened 7 years ago
Closed 7 years ago
Implement Console.timeLog(optional DOMString label = "default")
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
(Keywords: dev-doc-needed)
Attachments
(1 file, 1 obsolete file)
25.34 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•7 years ago
|
||
The issue is still open. Probably this patch will require some changes.
Attachment #8972525 -
Flags: review?(bgrinstead)
Comment 2•7 years ago
|
||
Comment on attachment 8972525 [details] [diff] [review]
timeLog.patch
Review of attachment 8972525 [details] [diff] [review]:
-----------------------------------------------------------------
Nice and simple, looks good to me. Before landing anything, let's wait for the spec issue to be resolved on github since it sounds like it may still change. And then also we need to build the frontend for the feature (should be pretty easy - we can handle it here or in another bug as long as we are sure it'll ship in the same release as this).
Attachment #8972525 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Here a patch that implements console.timeLog("foo", any) as I suggested on github. If you like this patch, I think it's time to land it.
Attachment #8972525 -
Attachment is obsolete: true
Attachment #8974316 -
Flags: review?(bgrinstead)
Comment 4•7 years ago
|
||
Comment on attachment 8974316 [details] [diff] [review]
timeLog.patch
Review of attachment 8974316 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/console/tests/test_timer.html
@@ +73,5 @@
> + ("error" in obj.timer);
> + });
> + console.timeLog('test');
> + await cl;
> + ok(true, "Console.time with error received!");
Nit: "Console.timeLog" instead of "Console.time".
Attachment #8974316 -
Flags: review?(bgrinstead) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3facc042d321
Implement Console.timeLog(optional DOMString label = "default"), r=bgrins
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e42c3ae89de0
Implement Console.timeLog(optional DOMString label = "default") - fixed an intermittent failure, r=me
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3facc042d321
https://hg.mozilla.org/mozilla-central/rev/e42c3ae89de0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Updated•7 years ago
|
Keywords: dev-doc-needed
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•