1458483 - Display human-readable Unicode characters instead of punycode / URL-encoded domain/filenames in the application panel

Status: RESOLVED FIXED

(DevTools :: Application Panel, enhancement)

Description

[Belén [:ladybenko]]

See the issues / patches provided here https://bugzilla.mozilla.org/show_bug.cgi?id=1448553

Comment 1

[Patrick Brosset <:pbro>]

Mass move to the new application panel component.

Comment 2

[Belén [:ladybenko]]

Attachment: Bug 1458483 - Application panel: display Unicode instead of encoded/punycode in URLs and filenames.

Review commit: https://reviewboard.mozilla.org/r/242014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242014/

Comment 3

[Belén [:ladybenko]]

Comment on attachment 8973646 [details]
Bug 1458483 - Application panel: display Unicode instead of encoded/punycode in URLs and filenames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242014/diff/1-2/

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8973646 [details]
Bug 1458483 - Application panel: display Unicode instead of encoded/punycode in URLs and filenames.

https://reviewboard.mozilla.org/r/242014/#review247906

Looks good, thanks Belén! Some comments, but this doesn't require another review round.

::: devtools/client/application/test/browser_application_panel_list-unicode.js:9
(Diff revision 2)
> +"use strict";
> +
> +const TAB_URL = (URL_ROOT + "service-workers/simple-unicode.html")
> +  .replace("example.com", "xn--hxajbheg2az3al.xn--jxalpdlp");
> +
> +console.log(TAB_URL);

We should remove this console.log.

::: devtools/client/application/test/browser_application_panel_list-unicode.js:11
(Diff revision 2)
> +const TAB_URL = (URL_ROOT + "service-workers/simple-unicode.html")
> +  .replace("example.com", "xn--hxajbheg2az3al.xn--jxalpdlp");
> +
> +console.log(TAB_URL);
> +
> +add_task(async function() {

Can we add a short comment to describe what this is testing?

::: devtools/client/application/test/browser_application_panel_list-unicode.js:32
(Diff revision 2)
> +    "Service worker has the expected Unicode scope"
> +  );
> +  let urlEl = workerContainer.querySelector(".js-source-url");
> +  ok(
> +    urlEl.textContent.endsWith("\u65E5\u672C"),
> +    "Service worker has the expected Unicode scope"

This should probably say "has the expected worker URL" or something similar?

Comment 5

[Belén [:ladybenko]]

Comment on attachment 8973646 [details]
Bug 1458483 - Application panel: display Unicode instead of encoded/punycode in URLs and filenames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242014/diff/2-3/

Comment 6

[Belén [:ladybenko]]

Fixed the quick changes you :julian proposed, marking the bug for checkin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcd37f61dcfc
Application panel: display Unicode instead of encoded/punycode in URLs and filenames. r=jdescottes

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fcd37f61dcfc