Closed
Bug 1458483
Opened 6 years ago
Closed 6 years ago
Display human-readable Unicode characters instead of punycode / URL-encoded domain/filenames in the application panel
Categories
(DevTools :: Application Panel, enhancement)
DevTools
Application Panel
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: ladybenko, Assigned: ladybenko)
References
Details
Attachments
(1 file)
See the issues / patches provided here https://bugzilla.mozilla.org/show_bug.cgi?id=1448553
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → balbeza
Assignee | ||
Updated•6 years ago
|
Blocks: devtools-app-panel
Assignee | ||
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Mass move to the new application panel component.
Component: Developer Tools → Developer Tools: Application Panel
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8973646 [details] Bug 1458483 - Application panel: display Unicode instead of encoded/punycode in URLs and filenames. https://reviewboard.mozilla.org/r/242014/#review247906 Looks good, thanks Belén! Some comments, but this doesn't require another review round. ::: devtools/client/application/test/browser_application_panel_list-unicode.js:9 (Diff revision 2) > +"use strict"; > + > +const TAB_URL = (URL_ROOT + "service-workers/simple-unicode.html") > + .replace("example.com", "xn--hxajbheg2az3al.xn--jxalpdlp"); > + > +console.log(TAB_URL); We should remove this console.log. ::: devtools/client/application/test/browser_application_panel_list-unicode.js:11 (Diff revision 2) > +const TAB_URL = (URL_ROOT + "service-workers/simple-unicode.html") > + .replace("example.com", "xn--hxajbheg2az3al.xn--jxalpdlp"); > + > +console.log(TAB_URL); > + > +add_task(async function() { Can we add a short comment to describe what this is testing? ::: devtools/client/application/test/browser_application_panel_list-unicode.js:32 (Diff revision 2) > + "Service worker has the expected Unicode scope" > + ); > + let urlEl = workerContainer.querySelector(".js-source-url"); > + ok( > + urlEl.textContent.endsWith("\u65E5\u672C"), > + "Service worker has the expected Unicode scope" This should probably say "has the expected worker URL" or something similar?
Attachment #8973646 -
Flags: review?(jdescottes) → review+
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•6 years ago
|
||
Fixed the quick changes you :julian proposed, marking the bug for checkin
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fcd37f61dcfc Application panel: display Unicode instead of encoded/punycode in URLs and filenames. r=jdescottes
Keywords: checkin-needed
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fcd37f61dcfc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•