145849 - Non-maintainers with ability to bless others need "users" link in footer

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Joel Peshkin]

Non-maintainers who have been granted the ability to enable particular 
permissions for other users need a link to the editusers.cgi script from their 
page footer.

Comment 1

[Joel Peshkin]

Attachment: Patch to 2.16-ish bugzillas adding "users" link for anyone with bless capabilities

This patch adds the numerical value of the blessgroupset to the user data
structure and uses a non-zero value to decide to include the edit users link in
the page footer.

Comment 2

[Dave Miller [:justdave]]

good catch

Comment 3

[Bradley Baetz (:bbaetz)]

Isn't this a dupe? I'm sure I've seen this before, somewhere.

That diff is wrong, though - you've included data/template (which you
shouldn't), but the compiled template only has a modtime change....

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 84373 [details] [diff] [review]
Patch to 2.16-ish bugzillas adding "users" link for anyone with bless capabilities

nit:

the change to CGI.pl is only whitespace

nit:

data/template is generated by TT2, it's not in cvs

change to useful-link.html.tmpl looks pretty self-explanatory, so it gets my
r=, but I'll leave it open for second by one of the people that normally deals
with templates.

Comment 5

[Joel Peshkin]

Attachment: Fixed patch for 2.16-ish bugzillas

DOH!

Somehow, I posted the differrence between the patch and the patch that was
cleaned up instead of the original.   Here's the correct one.  I've got to stop
doing these when I am asleep.

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 84379 [details] [diff] [review]
Fixed patch for 2.16-ish bugzillas

aha, yes, this looks much better.

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 84379 [details] [diff] [review]
Fixed patch for 2.16-ish bugzillas

Spot on.

Gerv

Comment 8

[Gervase Markham [:gerv]]

Checked in on trunk and branch.

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.153.2.1; previous revision: 1.153
done
Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.2.2.1; previous revision: 1.2
done

Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.154; previous revision: 1.153
done

Gerv