Closed Bug 1458548 Opened 7 years ago Closed 7 years ago

implementing atk scrollto interface

Categories

(Core :: Disability Access APIs, defect, P3)

Product:
Core
Component:
Disability Access APIs
Version:
59 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox62 --- fixed

People

(Reporter: samuel.thibault, Assigned: samuel.thibault)

Details

Attachments

(1 file, 2 obsolete files)

proposed implementation
5.84 KB, patch
surkov
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 Build ID: 20180326232916 Expected results: at-spi2 is currently adding a scrollto API (see https://bugzilla.gnome.org/show_bug.cgi?id=793587), which firefox should Implement. I am attaching a proposed patch so the firefox side can be reviewed while the interface is getting released on the at-spi2 side. Note that this can't be built as such of course, since a newer version of atk is needed. I'll also attach the patch which I use to update the atk layer.
Attachment #8972575 - Attachment is patch: true
Attached patch atk-scrollto (obsolete) — — Splinter Review
This is the patch which I use to update the atk layer. Since this is extending the struct _AtkComponentIface, it means stricly depending on the future atk >= 2.30.
Attachment #8972575 - Flags: review?(surkov.alexander)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → samuel.thibault
Ah, there is IsAtkVersionAtLeast() which should work to dynamically enable it or not, I'll add an if there and resubmit a patch + submit to test servers.
Attachment #8972575 - Flags: review?(surkov.alexander) → review+
Here they are combined, and being build-tested on https://treeherder.mozilla.org/#/jobs?repo=try&revision=15a1c2ad2e626c1ba92b9c1c5174c34299784235
Attachment #8972575 - Attachment is obsolete: true
Attachment #8972576 - Attachment is obsolete: true
Attachment #8972611 - Flags: review?(surkov.alexander)
Attachment #8972611 - Flags: review?(surkov.alexander) → review+
I'm guessing this issue belongs to the Disability Access API component, so triaging it there for now.
status-firefox59: --- → unaffected
status-firefox60: --- → unaffected
status-firefox-esr52: --- → unaffected
status-firefox-esr60: --- → unaffected
Component: Untriaged → Disability Access APIs
Product: Firefox → Core
Keywords: checkin-needed
Priority: -- → P3
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9caf187e649b atk: Implement scrollto ATK API. r=surkov
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9caf187e649b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: