Closed Bug 1458584 Opened 2 years ago Closed 2 years ago

Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css

Categories

(Toolkit :: XUL Widgets, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bgrins, Assigned: Paolo)

References

Details

Attachments

(1 file)

The scrollbar-base binding only loads a stylesheet. It's a pretty simple sheet, mostly used to set -moz-appearance and images: https://searchfox.org/mozilla-central/search?q=scrollbox.css&redirect=true.

This could be imported into components.css and the binding could be removed: https://dxr.mozilla.org/mozilla-central/rev/d2a4720d1c334b64d88a51678758c27ba8f03c89/toolkit/content/widgets/scrollbox.xml#12-16.

Any binding currently inheriting from it could directly inherit from basecontrol instead. Or even better, could stop inheriting from anything depending on if we rely on them being basecontrols.
Component: XUL → XUL Widgets
Product: Core → Toolkit
Triage: code cleanup.
Priority: -- → P5
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P5 → P1
Comment on attachment 8979221 [details]
Bug 1458584 - Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css.

https://reviewboard.mozilla.org/r/245450/#review251450

Thanks!
Attachment #8979221 - Flags: review?(bgrinstead) → review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13ae2716c71e
Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css. r=bgrins
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2fc440dae2c
Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css. r=bgrins
Re-landed since this is unrelated to the failing test.
Flags: needinfo?(paolo.mozmail)
https://hg.mozilla.org/mozilla-central/rev/f2fc440dae2c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.