Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css

RESOLVED FIXED in Firefox 62

Status

()

task
P1
normal
RESOLVED FIXED
Last year
21 days ago

People

(Reporter: bgrins, Assigned: Paolo)

Tracking

(Blocks 1 bug)

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

Last year
The scrollbar-base binding only loads a stylesheet. It's a pretty simple sheet, mostly used to set -moz-appearance and images: https://searchfox.org/mozilla-central/search?q=scrollbox.css&redirect=true.

This could be imported into components.css and the binding could be removed: https://dxr.mozilla.org/mozilla-central/rev/d2a4720d1c334b64d88a51678758c27ba8f03c89/toolkit/content/widgets/scrollbox.xml#12-16.

Any binding currently inheriting from it could directly inherit from basecontrol instead. Or even better, could stop inheriting from anything depending on if we rely on them being basecontrols.
Reporter

Updated

Last year
Component: XUL → XUL Widgets
Product: Core → Toolkit
Triage: code cleanup.
Priority: -- → P5
Assignee

Updated

Last year
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P5 → P1
Reporter

Comment 3

Last year
mozreview-review
Comment on attachment 8979221 [details]
Bug 1458584 - Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css.

https://reviewboard.mozilla.org/r/245450/#review251450

Thanks!
Attachment #8979221 - Flags: review?(bgrinstead) → review+

Comment 4

Last year
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13ae2716c71e
Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css. r=bgrins

Comment 6

Last year
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2fc440dae2c
Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css. r=bgrins
Assignee

Comment 7

Last year
Re-landed since this is unrelated to the failing test.
Flags: needinfo?(paolo.mozmail)

Comment 8

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/f2fc440dae2c
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62

Updated

21 days ago
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.