1458605 - Layout panel Grid Overlay uses checkbox controls even though the behavior is a radio control

Status: RESOLVED DUPLICATE of bug 1317102

(DevTools :: Inspector, defect)

Description

[Mats Palmgren (inactive)]

STEPS TO REPRODUCE
1. load a page with more than one display:grid element, for example:
   data:text/html,<div style=display:grid></div><div style=display:grid></div>
2. Open devtools Layout panel
3. click on one of the "Overlay Grid" controls, then the next one

ACTUAL RESULTS
The first selected grid overlay is unselected, i.e. this is a radio control

EXPECTED RESULTS
The control is currently rendered as a checkbox, thus indicating that
this is a multiple choice control.  If that is intended, then it should
be possible to select more than one grid overlay simultaneously.

If selecting more than one is not intended, then these controls should
be rendered as <input type=radio> to make that clear to the user.
It's really confusing to render a form control that doesn't match
its behavior.

Bug occurs in "Nightly 61.0a1 (2018-05-01) (64-bit)" on Linux (at least).

Comment 1

[Mats Palmgren (inactive)]

Attachment: screenshot

Comment 2

[Patrick Brosset <:pbro>]

Yes because the intention was that we would make it possible to toggle more than 1 grid highlighters on the page at a time.
We haven't had much time to work on this particular feature in the recent past and the single selection has proven really useful for people already.

I tend to agree with the bug report and think that we should transform this into radio buttons.
Except if we enable multi-selection very soon and want to preserve the expectations from people that this will start working soon.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

No need to fix this since we will make multiple grid highlighting happen in Bug 1317102