1458751 - Lazy load StyleInspectorMenu, KeyShortscut and clipboardHelper in CssRuleView and CssComputedView

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1458751 - Lazy load StyleInspectorMenu, KeyShortscut and clipboardHelper in CssRuleView and CssComputedView.

Review commit: https://reviewboard.mozilla.org/r/241292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241292/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e548f840e355ffe53ad5c191d3803c1bfbfc2eb7

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

damp https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=6a33091e1a02314bd324f302b665df4e8722be72

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8972748 [details]
Bug 1458751 - Lazy load StyleInspectorMenu, KeyShortscut and clipboardHelper in CssRuleView and CssComputedView.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241292/diff/1-2/

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=80c0275c0739af1261f85d2f930b4c099d54dee5

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8972748 [details]
Bug 1458751 - Lazy load StyleInspectorMenu, KeyShortscut and clipboardHelper in CssRuleView and CssComputedView.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241292/diff/2-3/

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

DAMP https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=6143c2b188cc6089dbd40961c670fbe48417d762
try revisions for comparison https://treeherder.mozilla.org/#/jobs?repo=try&revision=75fdf614386196d16dc731ea39e40789f03cd027

Comment 8

[Patrick Brosset <:pbro>]

Comment on attachment 8972748 [details]
Bug 1458751 - Lazy load StyleInspectorMenu, KeyShortscut and clipboardHelper in CssRuleView and CssComputedView.

https://reviewboard.mozilla.org/r/241292/#review247216

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f9fc394b2c4
Lazy load StyleInspectorMenu, KeyShortscut and clipboardHelper in CssRuleView and CssComputedView. r=pbro

Comment 10

[Dorel Luca [:dluca]]

Backed out 4 changesets (bug 1458791, bug 1458769, bug 1458751, bug 1458758) for Mochitest failure on multiple files. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=176763984&repo=mozilla-inbound&lineNumber=5103

INFO - TEST-INFO | started process screencapture
07:07:12     INFO - TEST-INFO | screencapture: exit 0
07:07:12     INFO - Buffered messages logged at 07:07:08
07:07:12     INFO - Entering test bound 
07:07:12     INFO - Adding a new tab with URL: data:text/html;charset=utf-8,%0A%20%20%3Cstyle%20type%3D%22text%2Fcss%22%3E%0A%20%20%20%20span%20%7B%0A%20%20%20%20%20%20font-variant-caps%3A%20small-caps%3B%0A%20%20%20%20%20%20color%3A%20%23000000%3B%0A%20%20%20%20%7D%0A%20%20%20%20.nomatches%20%7B%0A%20%20%20%20%20%20color%3A%20%23ff0000%3B%0A%20%20%20%20%7D%0A%20%20%3C%2Fstyle%3E%0A%20%20%3Cdiv%20id%3D%22first%22%20style%3D%22margin%3A%2010em%3B%0A%20%20%20%20font-size%3A%2014pt%3B%20font-family%3A%20helvetica%2C%20sans-serif%3B%20color%3A%20%23AAA%22%3E%0A%20%20%20%20%3Ch1%3ESome%20header%20text%3C%2Fh1%3E%0A%20%20%20%20%3Cp%20id%3D%22salutation%22%20style%3D%22font-size%3A%2012pt%22%3Ehi.%3C%2Fp%3E%0A%20%20%20%20%3Cp%20id%3D%22body%22%20style%3D%22font-size%3A%2012pt%22%3EI%20am%20a%20test-case.%20This%20text%20exists%0A%20%20%20%20solely%20to%20provide%20some%20things%20to%20%3Cspan%20style%3D%22color%3A%20yellow%22%3E%0A%20%20%20%20highlight%3C%2Fspan%3E%20and%20%3Cspan%20style%3D%22font-weight%3A%20bold%22%3Ecount%3C%2Fspan%3E%0A%20%20%20%20style%20list-items%20in%20the%20box%20at%20right.%20If%20you%20are%20reading%20this%2C%0A%20%20%20%20you%20should%20go%20do%20something%20else%20instead.%20Maybe%20read%20a%20book.%20Or%20better%0A%20%20%20%20yet%2C%20write%20some%20test-cases%20for%20another%20bit%20of%20code.%0A%20%20%20%20%3Cspan%20style%3D%22font-style%3A%20italic%22%3Esome%20text%3C%2Fspan%3E%3C%2Fp%3E%0A%20%20%20%20%3Cp%20id%3D%22closing%22%3Emore%20text%3C%2Fp%3E%0A%20%20%20%20%3Cp%3Eeven%20more%20text%3C%2Fp%3E%0A%20%20%3C%2Fdiv%3E%0A
07:07:12     INFO - Tab added and finished loading
07:07:12     INFO - Opening the inspector
07:07:12     INFO - Opening the toolbox
07:07:12     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/FileUtils.jsm" line: 170}]
07:07:12     INFO - Buffered messages logged at 07:07:10
07:07:12     INFO - Toolbox opened and focused
07:07:12     INFO - Buffered messages logged at 07:07:11
07:07:12     INFO - Selecting the computedview sidebar
07:07:12     INFO - Selecting the node for 'span'
07:07:12     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/NetUtil.jsm" line: 302}]
07:07:12     INFO - Buffered messages logged at 07:07:12
07:07:12     INFO - Testing selection copy
07:07:12     INFO - Create the text selection range
07:07:12     INFO - Trigger a copy event and wait for the clipboard content
07:07:12     INFO - TEST-PASS | devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-01.js | Clipboard has the given value: 'font-family: helvetica, sans-serif;
07:07:12     INFO - font-size: 16px;
07:07:12     INFO - font-variant-caps: small-caps;' - 
07:07:12     INFO - Selecting all the text
07:07:12     INFO - Buffered messages finished
07:07:12     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-01.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/computed/test/head.js:167 - TypeError: view._contextmenu is undefined
07:07:12     INFO - Stack trace:
07:07:12     INFO - selectAllText@chrome://mochitests/content/browser/devtools/client/inspector/computed/test/head.js:167:3
07:07:12     INFO - copyAllAndCheckClipboard@chrome://mochitests/content/browser/devtools/client/inspector/computed/test/head.js:179:3
07:07:12     INFO - async*testCopyAll@chrome://mochitests/content/browser/devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-01.js:61:9
07:07:12     INFO - async*@chrome://mochitests/content/browser/devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-01.js:41:9
07:07:12     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1083:34
07:07:12     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1074:16
07:07:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:976:9
07:07:12     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
07:07:12     INFO - Leaving test bound 
07:07:12     INFO - GECKO(905) | ++DOMWINDOW == 35 (0x12935cc00) [pid = 905] [serial = 38] [outer = 0x117230000]
07:07:12     INFO - GECKO(905) | --DOCSHELL 0x11c7b2800 == 9 [pid = 905] [id = {177214f1-49e7-8441-b546-837e72ed2e5c}]
07:07:13     INFO - GECKO(905) | --DOMWINDOW == 34 (0x1372eac00) [pid = 905] [serial = 21] [outer = 0x0] [url = about:blank]
07:07:13     INFO - GECKO(905) | --DOMWINDOW == 33 (0x12a43ac00) [pid = 905] [serial = 7] [outer = 0x0] [url = about:blank]
07:07:13     INFO - GECKO(905) | --DOMWINDOW == 32 (0x117238400) [pid = 905] [serial = 23] [outer = 0x0] [url = about:blank]
07:07:13     INFO - GECKO(905) | --DOMWINDOW == 31 (0x12bc6c000) [pid = 905] [serial = 11] [outer = 0x0] [url = about:blank]
07:07:13     INFO - GECKO(905) | --DOMWINDOW == 30 (0x12bc6b400) [pid = 905] [serial = 10] [outer = 0x0] [url = about:blank]
07:07:13     INFO - GECKO(905) | --DOCSHELL 0x117217800 == 8 [pid = 905] [id = {e0007245-d2e9-764f-a0ce-6f9059e8e6ac}]
07:07:13     INFO - GECKO(905) | --DOCSHELL 0x11daba000 == 7 [pid = 905] [id = {fac3be1e-0ce7-e249-95c1-5d78dc211f29}]
07:07:13     INFO - GECKO(905) | --DOCSHELL 0x12a328800 == 6 [pid = 905] [id = {f97ea667-ba64-9d4a-b674-d3cb33d5b2a0}]
07:07:13     INFO - GECKO(905) | --DOCSHELL 0x12a420800 == 5 [pid = 905] [id = {aa1a91ee-456b-0d4b-b2c2-aa16270c7e06}]
07:07:13     INFO - Removing tab.
07:07:13     INFO - Waiting for event: 'TabClose' on [object XULElement].
07:07:13     INFO - Got event: 'TabClose' on [object XULElement].
07:07:13     INFO - Tab removed and finished closing
07:07:13     INFO - GECKO(905) | --DOMWINDOW == 2 (0x121938c00) [pid = 907] [serial = 2] [outer = 0x0] [url = about:blank]
07:07:13     INFO - GECKO(905) | [Parent 905, Main Thread] WARNING: NS_ENSURE_TRUE(currentInner) failed: file /builds/worker/workspace/build/src/dom/base/WindowDestroyedEvent.cpp, line 109
07:07:13     INFO - GECKO(905) | MEMORY STAT | vsize 4454MB | residentFast 443MB | heapAllocated 112MB
07:07:13     INFO - TEST-OK | devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-01.js | took 5907ms
07:07:13     INFO - GECKO(905) | ++DOCSHELL 0x11d12d800 == 1 [pid = 908] [id = {ac405a1d-28c7-694d-9f19-a357fc38d23a}]
07:07:13     INFO - GECKO(905) | ++DOMWINDOW == 3 (0x1168eb400) [pid = 908] [serial = 3] [outer = 0x0]
07:07:13     INFO - GECKO(905) | ++DOMWINDOW == 4 (0x11dd9bc00) [pid = 908] [serial = 4] [outer = 0x1168eb400]
07:07:14     INFO - checking window state
07:07:14     INFO - TEST-START | devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-02.js

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8f9fc394b2c407b1fe5ac352bbd7c97c511ac117&selectedJob=176763984

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bcc98e23806594f2f9bccdd2596c37a5db7187d

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e33c9d292584
Lazy load StyleInspectorMenu, KeyShortscut and clipboardHelper in CssRuleView and CssComputedView. r=pbro

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e33c9d292584