1458760 - Set browser.startup.blankWindow to false on Linux

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Due to the black color problem mentioned in bug 1447719, let's disable the fast blank paint on Linux for now until we can investigate further mitigations.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Bug 1458760 - Set browser.startup.blankWindow to false on Linux in release versions.

Review commit: https://reviewboard.mozilla.org/r/241300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241300/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8972751 [details]
Bug 1458760 - Set browser.startup.blankWindow to false on Linux in release versions.

https://reviewboard.mozilla.org/r/241300/#review247294

I suggest enabling this on EARLY_BETA_OR_EARLIER for Linux instead. Happy to discuss though, if you disagree. See below.

::: browser/app/profile/firefox.js:254
(Diff revision 1)
>  pref("browser.startup.homepage",            "chrome://branding/locale/browserconfig.properties");
>  // Whether we should skip the homepage when opening the first-run page
>  pref("browser.startup.firstrunSkipsHomepage", true);
>  
>  // Show an about:blank window as early as possible for quick startup feedback.
> -#ifdef XP_MACOSX
> +#if defined(XP_MACOSX) || defined(MOZ_WIDGET_GTK)

So I spent some time this morning tinkering with the first blank feature on my Ubuntu box... I'm actually inclined to suggest that we put this behind the EARLY_BETA_OR_EARLIER build-time flag for Linux, to see if there's any useful feedback we can get from our Linux Beta population about the feature.

I don't think it can necessarily ship, as is, to release. But maybe the Beta population can give us a better sense of what we need to do to get it into that state.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8972751 [details]
Bug 1458760 - Set browser.startup.blankWindow to false on Linux in release versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241300/diff/1-2/

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Agreed that it would be useful to get some feedback from Linux users on early beta, thanks!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8972751 [details]
Bug 1458760 - Set browser.startup.blankWindow to false on Linux in release versions.

https://reviewboard.mozilla.org/r/241300/#review247690

Please don't land as is with my r+ (see below), but I don't think this needs more review - just a logic flip. See below.

::: browser/app/profile/firefox.js:254
(Diff revision 2)
>  pref("browser.startup.homepage",            "chrome://branding/locale/browserconfig.properties");
>  // Whether we should skip the homepage when opening the first-run page
>  pref("browser.startup.firstrunSkipsHomepage", true);
>  
>  // Show an about:blank window as early as possible for quick startup feedback.
> -#ifdef XP_MACOSX
> +#if defined(MOZ_WIDGET_GTK) && defined(EARLY_BETA_OR_EARLIER) || defined(XP_MACOSX)

I think we've got the logic reversed here. This is saying that if we're on Linux on early beta or earlier, to disable the feature.

I think this should work:

```
#if defined(MOZ_WIDGET_GTK) && !defined(EARLY_BETA_OR_EARLIER) || defined(XP_MACOSX)
/ Held to nightly and early beta on Linux due to bug 1450626.
// Disabled on Mac because the bouncing dock icon already provides feedback.
pref("browser.startup.blankWindow", false);
```

or maybe clearer:

```
#if defined(XP_WIN) || (defined(MOZ_WIDGET_GTK) && defined(EARLY_BETA_OR_EARLIER)
(enable pref)
#else
(disable pref)
#endif

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8972751 [details]
Bug 1458760 - Set browser.startup.blankWindow to false on Linux in release versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241300/diff/2-3/

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Thanks for catching this! I went with the clearer version you proposed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5980d2f915f
Set browser.startup.blankWindow to false on Linux in release versions. r=mconley

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c5980d2f915f