Closed Bug 1458770 Opened Last year Closed Last year

Use the toolbox's Telemetry instance in the Inspector

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

No description provided.
The purpose of this small change is to make the Inspector require one less thing for perf reasons. This is a series of small perf patches I am doing.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=90d7a532726eb6c84bdcbd76947cf80abf31e302
Attachment #8972763 - Flags: review?(jdescottes) → review?(pbrosset)
Attachment #8972763 - Flags: review?(pbrosset) → review?(mratcliffe)
Looks fine to me, but I'm not 100% sure of the impacts of reusing the toolbox's Telemetry instance. Every other tool seems to be instantiating its own Telemetry object.
I'd prefer if Mike took at look at this one.
Comment on attachment 8972763 [details]
Bug 1458770 - Use the toolbox's Telemetry instance in the Inspector.

https://reviewboard.mozilla.org/r/241328/#review247298
Comment on attachment 8972763 [details]
Bug 1458770 - Use the toolbox's Telemetry instance in the Inspector.

https://reviewboard.mozilla.org/r/241328/#review247502
Attachment #8972763 - Flags: review?(mratcliffe) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bc4513eef70
Use the toolbox's Telemetry instance in the Inspector. r=miker
https://hg.mozilla.org/mozilla-central/rev/5bc4513eef70
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.