1458783 - Intermittent dom/events/test/test_bug574663.html | Momentum scrolling should scroll, even when pressing Ctrl - got 6, expected 18

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Treeherder Bug Filer]

Filed by: rgurzau [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=176689535&repo=autoland

https://queue.taskcluster.net/v1/task/FFZRQ1jwQjSfgz2jZlaRxA/runs/0/artifacts/public/logs/live_backing.log

[task 2018-05-03T02:52:07.905Z] 02:52:07     INFO - TEST-START | dom/events/test/test_bug574663.html
[task 2018-05-03T02:52:08.535Z] 02:52:08     INFO - TEST-INFO | started process screentopng
[task 2018-05-03T02:52:09.311Z] 02:52:09     INFO - TEST-INFO | screentopng: exit 0
[task 2018-05-03T02:52:09.315Z] 02:52:09     INFO - Buffered messages logged at 02:52:08
[task 2018-05-03T02:52:09.315Z] 02:52:09     INFO - must wait for load
[task 2018-05-03T02:52:09.315Z] 02:52:09     INFO - must wait for focus
[task 2018-05-03T02:52:09.316Z] 02:52:09     INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom 
[task 2018-05-03T02:52:09.316Z] 02:52:09     INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll 
[task 2018-05-03T02:52:09.317Z] 02:52:09     INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling shouldn't change zoom, even after releasing the touchpad 
[task 2018-05-03T02:52:09.318Z] 02:52:09     INFO - TEST-PASS | dom/events/test/test_bug574663.html | Normal scrolling should scroll, even after releasing the touchpad 
[task 2018-05-03T02:52:09.320Z] 02:52:09     INFO - TEST-PASS | dom/events/test/test_bug574663.html | Ctrl-scrolling should zoom while the user is touching the touchpad 
[task 2018-05-03T02:52:09.321Z] 02:52:09     INFO - TEST-PASS | dom/events/test/test_bug574663.html | Ctrl-scrolling shouldn't scroll while the user is touching the touchpad 
[task 2018-05-03T02:52:09.326Z] 02:52:09     INFO - TEST-PASS | dom/events/test/test_bug574663.html | Momentum scrolling shouldn't zoom, even when pressing Ctrl 
[task 2018-05-03T02:52:09.327Z] 02:52:09     INFO - Buffered messages finished
[task 2018-05-03T02:52:09.329Z] 02:52:09     INFO - TEST-UNEXPECTED-FAIL | dom/events/test/test_bug574663.html | Momentum scrolling should scroll, even when pressing Ctrl - got 6, expected 18

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Botond, this fails frequently and looks like fallout from bug 1458063. Please investigate or let us know if it shall get backed out.

Comment 5

[Intermittent Failures Robot]

45 failures in 102 pushes (0.441 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 21
* mozilla-inbound: 10
* mozilla-central: 7
* try: 6
* mozilla-beta: 1

Platform breakdown:
* windows7-32: 28
* linux64: 12
* windows10-64: 4
* windows7-32-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1458783&startday=2018-05-03&endday=2018-05-03&tree=trunk

Comment 6

[Botond Ballo [:botond]]

Bisection is showing that the intermittent failure is caused by the first patch from bug 1458063. As it happens, that patch is not actually necessarily to accomplish the goals of bug 1458063 (see bug 1458063 comment 17).

I'd like to investigate some more to better understand _why_ that patches causes the intermittent (as it's not clear to me), but we can start by backing it out for now.

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1458783 - Back out the first patch in bug 1458063 (propagate wheel event modifiers in APZInputBridge::ReceiveInputEvent).

The patch in question is not strictly necessary to fix bug 1458063, and was
causing intermittent failures.

Review commit: https://reviewboard.mozilla.org/r/241774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241774/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8973300 [details]
Bug 1458783 - Back out the first patch in bug 1458063 (propagate wheel event modifiers in APZInputBridge::ReceiveInputEvent).

https://reviewboard.mozilla.org/r/241774/#review247640

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1120a82a5604
Back out the first patch in bug 1458063 (propagate wheel event modifiers in APZInputBridge::ReceiveInputEvent). r=kats

Comment 10

[Intermittent Failures Robot]

79 failures in 125 pushes (0.632 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 32
* autoland: 27
* mozilla-central: 12
* try: 5
* mozilla-beta: 3

Platform breakdown:
* windows7-32: 53
* linux64: 15
* windows10-64: 9
* windows7-32-nightly: 1
* windows7-32-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1458783&startday=2018-05-04&endday=2018-05-04&tree=trunk

Comment 11

[Guilherme Lima]

https://hg.mozilla.org/mozilla-central/rev/1120a82a5604 (landed 17 hours ago)

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1120a82a5604

Comment 13

[Intermittent Failures Robot]

128 failures in 551 pushes (0.232 failures/push) were associated with this bug in the last 7 days. 

This is the #7 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 53
* mozilla-inbound: 41
* mozilla-central: 20
* try: 10
* mozilla-beta: 4

Platform breakdown:
* windows7-32: 84
* linux64: 28
* windows10-64: 12
* windows7-32-nightly: 2
* windows7-32-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1458783&startday=2018-04-30&endday=2018-05-06&tree=trunk