1458794 - On nightly, UI for Proxy has 'Use system Proxy Settings' and 'Auto-detect proxy settings for this network' mixed up

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[polly.shaw]

If you go to the options page in Nightly, and select 'Auto-detect proxy settings for this network' then the system proxy is used. It is also possible to confirm this by going to 'about:config' and confirming that network.proxy.type is 5. Vice versa, if you choose 'Use system proxy settings' then the network proxy is auto-detected (and can be confirmed to be set to 4 in the about:config.)

Have confirmed that this is not an issue in Firefox 58.0.2.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Good catch, polly.shaw! Yeah, this seems like a regression from this changeset: https://hg.mozilla.org/mozilla-central/rev/7870682a569da34d00e140742a4a2c3961e6d16d (Bug 1451992).

Hey gandalf, got time for this one too? I think we just need to flip the keys around (and maybe do a quick audit to ensure the mapping from key-values to radio values matches the pre-Fluent one).

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1458794 - swap system/auto proxy config labels and access keys (oops),

Review commit: https://reviewboard.mozilla.org/r/241446/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241446/

Comment 3

[:Gijs (he/him)]

Stealing this. :-)

Comment 4

[:Gijs (he/him)]

(also, ugh, sorry for not catching this in review...)

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8972897 [details]
Bug 1458794 - swap system/auto proxy config labels and access keys (oops),

https://reviewboard.mozilla.org/r/241446/#review247370

silly me. Thank you! Glad we don't need l10n changes :D

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35fc3ebc6454
swap system/auto proxy config labels and access keys (oops), r=gandalf

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/35fc3ebc6454