Closed Bug 1458794 Opened 2 years ago Closed 2 years ago

On nightly, UI for Proxy has 'Use system Proxy Settings' and 'Auto-detect proxy settings for this network' mixed up

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- fixed

People

(Reporter: polly.shaw, Assigned: Gijs)

References

Details

(Keywords: regression)

Attachments

(1 file)

If you go to the options page in Nightly, and select 'Auto-detect proxy settings for this network' then the system proxy is used. It is also possible to confirm this by going to 'about:config' and confirming that network.proxy.type is 5. Vice versa, if you choose 'Use system proxy settings' then the network proxy is auto-detected (and can be confirmed to be set to 4 in the about:config.)

Have confirmed that this is not an issue in Firefox 58.0.2.
Good catch, polly.shaw! Yeah, this seems like a regression from this changeset: https://hg.mozilla.org/mozilla-central/rev/7870682a569da34d00e140742a4a2c3961e6d16d (Bug 1451992).

Hey gandalf, got time for this one too? I think we just need to flip the keys around (and maybe do a quick audit to ensure the mapping from key-values to radio values matches the pre-Fluent one).
Blocks: 1451992
Flags: needinfo?(gandalf)
Priority: -- → P1
Stealing this. :-)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gandalf)
(also, ugh, sorry for not catching this in review...)
Comment on attachment 8972897 [details]
Bug 1458794 - swap system/auto proxy config labels and access keys (oops),

https://reviewboard.mozilla.org/r/241446/#review247370

silly me. Thank you! Glad we don't need l10n changes :D
Attachment #8972897 - Flags: review?(gandalf) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/35fc3ebc6454
swap system/auto proxy config labels and access keys (oops), r=gandalf
https://hg.mozilla.org/mozilla-central/rev/35fc3ebc6454
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.