Closed Bug 1458821 Opened 3 years ago Closed 3 years ago
IAsync File Metadata .async Wait to async File Metadata Wait
This was discussed in bug 1434553.
Comment on attachment 8972808 [details] [diff] [review] fs_0.patch Not sure which one is better, asyncFileMetadataWait or asyncWait(For)FileMetadata. I guess it depends on the naming convention elsewhere.
Attachment #8972808 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #2) > Not sure which one is better, > asyncFileMetadataWait or asyncWait(For)FileMetadata. > I guess it depends on the naming convention elsewhere. asyncWait(For)FileMetadata has the advantage that a naive searchfox query for "asyncWait" will find both it and the normal "asyncWait" symbol.
hmm, that might be actually a disadvantage. the method is quite different to the normal asyncWait
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/c07fc14c5821 Rename nsIAsyncFileMetadata.asyncWait to asyncFileMetadataWait, r=smaug
You need to log in before you can comment on or make changes to this bug.