1458821 - Rename nsIAsyncFileMetadata.asyncWait to asyncFileMetadataWait

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Andrea Marchesini [:baku]]

This was discussed in bug 1434553.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fs_0.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8972808 [details] [diff] [review]
fs_0.patch

Not sure which one is better, 
asyncFileMetadataWait or asyncWait(For)FileMetadata.
I guess it depends on the naming convention elsewhere.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Not sure which one is better, 
> asyncFileMetadataWait or asyncWait(For)FileMetadata.
> I guess it depends on the naming convention elsewhere.

asyncWait(For)FileMetadata has the advantage that a naive searchfox query for "asyncWait" will find both it and the normal "asyncWait" symbol.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

hmm, that might be actually a disadvantage. the method is quite different to the normal asyncWait

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c07fc14c5821
Rename nsIAsyncFileMetadata.asyncWait to asyncFileMetadataWait, r=smaug

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c07fc14c5821