1458842 - Address bar is not focused when opening new window with custom extension page as homepage

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect, P3)

Description

[juraj.masiar]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180428110614

Steps to reproduce:

Using new 61.0b1 (64-bit)
1) install https://addons.mozilla.org/en-US/firefox/addon/groupspeeddial/
2) set it as homepage (there are instructions in the Options page / first tab / first line). Basically the URL should look like this: "moz-extension://7fadbe7c-ddea-4601-b739-dc9b35b0cc83/dial.html"
3) open new Firefox window


Actual results:

Address bar is not focused.


Expected results:

Address bar should be focused the same way as it is when opening new tab page.

This bug was introduced in by current Beta 61.0b1.

Comment 1

[Andrew Swan [:aswan]]

I suspect this is intentional, I see the same thing any time the home page is set to a custom URL.
Adjust the component so somebody who handles the home page preference can take a look but I suspect this will be WONTFIX.

Comment 2

[juraj.masiar]

I understand the use-case with the custom URL. 
But there is another use-case - user just want to have same behavior when he opens new tab or new window (for me there is no difference and I see this as inconsistency).

There still time to fix this, for example by:
- new setting in Firefox Options page to control focus in New tab and New window
- allow web-extensions (at least custom web-extension pages) to control focus - I really don't see why not

This issue will affect all users with custom add-on page as homepage.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I'm not really sure this falls under Preferences - it's true that the UI to set this configuration is in Preferences, but the actual URL bar focusing behaviour is what we seem to care about here.

Maybe Address Bar is a better component?

Comment 4

[Drew Willcoxon :adw]

I spent some time debugging this.  It looks like we correctly focus the urlbar (via focusAndSelectUrlBar()), but then later when the url is actually loaded, SessionStore focuses the browser, here: https://dxr.mozilla.org/mozilla-central/rev/42880a726964a0bd66e2f636931e8322eae86ef7/browser/components/sessionstore/SessionStore.jsm#4022

When I comment out that line, the urlbar remains focused when doing the STR in comment 0.

Dumping the call stack in the urlbar's blur handler:

onxblblur@chrome://browser/content/urlbarBindings.xml:1681:9
restoreTabContent@resource:///modules/sessionstore/SessionStore.jsm:4022:7
restoreTab@resource:///modules/sessionstore/SessionStore.jsm:3896:9
navigateAndRestore/<@resource:///modules/sessionstore/SessionStore.jsm:3050:7
MessageListener.receiveMessage*onLoad/<@resource:///modules/sessionstore/SessionStore.jsm:1099:7
onLoad@resource:///modules/sessionstore/SessionStore.jsm:1097:5
onBeforeBrowserWindowShown@resource:///modules/sessionstore/SessionStore.jsm:1279:5
ssi_observe@resource:///modules/sessionstore/SessionStore.jsm:767:9
onLoad@chrome://browser/content/browser.js:1352:5
onload@chrome://browser/content/browser.xul:1:1

Maybe SessionStore should keep the focus in the urlbar, but I don't know enough about it to say.  But I'll move this bug to SessionStore.

Comment 5

[god]

As a long time Firefox user (since v0.74 if I'm not mistaken, when Mozilla was considered the "stable" version of Firefox), I suddenly found out that this new "feature" is annoying as hell: I now have to open a new tab (ctrl+t) with my keyboard and then press Fn+F6 to select the address bar. Every. Time. I. Open. A. New. Tab. Which happens often.

Firefox Quantum was a bit of an annoyance because the text in the address bar wasn't selected, but at least the combo Ctrl+t and Ctrl+a was easy to do and the general speed improvement of the browser was very notorious.

Please let us users decide where we want the focus to be on when we open a new tab, either in about:config or via GUI.

Greetings.

Comment 6

[juraj.masiar]

I feel your pain!

However for me this affects only opening new window (using Ctrl + N), not New tab. There may be something else going on in your case - you may want to try to create new profile to test it out:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles 

Also I think it's easier to use Ctrl + L shortcut to focus the address-bar or Ctrl + K to focus search bar (if you have them merged, it will be the same).

Comment 7

[Robert AB]

I think that there are more important bugs to fix than this one.
Please, check these ones: Bug 1235231, Bug 394492, Bug 1435077

Comment 8

[juraj.masiar]

I agree bugs should be fixed in the proper order - however if the issue is already identified (as per comment 4) and all it takes is remove one line and run the tests, then why not do it right now. Especially if it's new bug introduced only in 61.

Comment 9

[juraj.masiar]

I'm not sure if somebody was secretly working on this but this bug is now fixed in Beta 65.0b3 and Nightly 66.

Comment 10

[Drew Willcoxon :adw]

Marking fixed per comment 9.