1458927 - Fix squared distance computation for Perspective.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Followup to bug 1458715, which I couldn't land because it broke a test that relied on the specific value.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1458927: Fix perspective squared distance computation.

Review commit: https://reviewboard.mozilla.org/r/241464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241464/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8972908 [details]
Bug 1458927: Fix perspective squared distance computation.

https://reviewboard.mozilla.org/r/241464/#review247400

Thanks! 

I believe this is the right thing to do, given that 'perspective' property is defined as animatable as length.  (This is for perspective function in transform property though)

https://drafts.csswg.org/css-transforms-2/#propdef-perspective

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Gosh.  I wanted to leave NI to Boris since he can audit this change when we come back. But unfortunately he don't accept NI for now.  I am leaving NI to myself instead.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d42fb2ba68a4
Fix perspective squared distance computation. r=hiro

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d42fb2ba68a4

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Boris, I've heard you come back today on July 2nd.
I believe the change here is a proper fix, but I'd like you to check this too.
Thanks and welcome back!

Comment 7

[Boris Chiou [:boris]]

This should be fine. We don't have spec to define the distance between two perspective() functions. I used "1/x" for this only because I'd like to compute the distance as the perspective transformed matrix.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Thank you, Boris!