Closed Bug 1458927 Opened 3 years ago Closed 3 years ago
Fix squared distance computation for Perspective
59 bytes, text/x-review-board-request
Followup to bug 1458715, which I couldn't land because it broke a test that relied on the specific value.
Comment on attachment 8972908 [details] Bug 1458927: Fix perspective squared distance computation. https://reviewboard.mozilla.org/r/241464/#review247400 Thanks! I believe this is the right thing to do, given that 'perspective' property is defined as animatable as length. (This is for perspective function in transform property though) https://drafts.csswg.org/css-transforms-2/#propdef-perspective
Attachment #8972908 - Flags: review?(hikezoe) → review+
Gosh. I wanted to leave NI to Boris since he can audit this change when we come back. But unfortunately he don't accept NI for now. I am leaving NI to myself instead.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d42fb2ba68a4 Fix perspective squared distance computation. r=hiro
Boris, I've heard you come back today on July 2nd. I believe the change here is a proper fix, but I'd like you to check this too. Thanks and welcome back!
Flags: needinfo?(hikezoe) → needinfo?(boris.chiou)
This should be fine. We don't have spec to define the distance between two perspective() functions. I used "1/x" for this only because I'd like to compute the distance as the perspective transformed matrix.
Thank you, Boris!
You need to log in before you can comment on or make changes to this bug.