145896 - Chimera ignores all settings in PageSetup

Status: VERIFIED FIXED

(Camino Graveyard :: Printing, defect)

Description

[Chris Petersen]

Build: 0.2.7
Platform: OS X 10.1.4
Expected Results: Page should be printing in landscape mode
What I got: Page is printed in Portriat mode rather than Landscape mode

Steps to reproduce:

1) Go to site like mozilla.or or view a jpg image like
http://dcresource.com/reviews/fuji/finepix_f601-review/DSCF0069-pp.JPG

2) From page setup, click on either landscape icons in the Orientation section.
Click OK.

3) Select Print from File menu. Click on Preview. Preview app should open
showing the content is displayed in Portriat rather than Landscape.

Comment 1

[Greg K.]

Confirmed using Chimera/20020602. Landscape orientation setting is apparently
ignored.

Comment 2

[saari (gone)]

->pinkerton, who did the printing code? (yeah, I know, hyatt)

Comment 3

[Mike Pinkerton (not reading bugmail)]

beard knows printing code *ducks*

Comment 4

[Winnie Lam]

Other printing issues (lemme know if you want me to create a separate bug):
From mozdev bug 1008 - Table data misplaced when printing to paper/pdf:
http://mozdev.org/bugs/show_bug.cgi?id=1008

This happens on:
Mac Powerbook G4 Titanium
Mac OS X 10.1.3.(5Q110) (Localized Swedish)

A simple table, 3x3 displays correct on screen.
When printed the table itself is printed correct but the contents of the table
are printed missplaced - and - table rows are printed in the wrong order.
Number = Cell, Letter = Row

On Screen:
A1 A2 A3
B1 B2 B3
C1 C2 C3

On Paper:
C1 C2 C3
B1 B2 B3
A1 A2 A3

An example is avaliable on
http://webtoprint.framkom.se/chimera/
The html file contains a simple 3x3 table.
The two PDF:s shows the result when printed from Chimera 0.2.0 and
from Internet Explorer 5.1 (latest public update).

Also
When the page is displayed on screen - chimera honers the width &
height attributes to <TABLE> but it doesn't when printed.

Comment 5

[Winnie Lam]

Another printing issue from mozdev bug 1023 -
http://mozdev.org/bugs/show_bug.cgi?id=1023

This bug is sort of an add-on to bug #1008. I've noticed the problem of
lines of text being printed out of order not only with tables, but with regular
text too. (last line first, first line last)

Comment 6

[Winnie Lam]

Regarding the two issues noted above (from
http://mozdev.org/bugs/show_bug.cgi?id=1034):

I believe these printing problems (#1023, #1008) result from NSView objects (and
subclasses) using a reversed coordinate system.
Point (0,0) is at the bottom left of your screen, not the top left like it has
been previously. You will have to compensate for this by subtracting by the page
size.

One more printing issue from mozdev 1056 -
http://mozdev.org/bugs/show_bug.cgi?id=1056

When printing a page with an alphabetized list, the order of the elements of the
list appears as c, b, a instead of a, b, c.

Comment 7

[Mike Pinkerton (not reading bugmail)]

ah-ha! perhaps our print view does not have its coordinate system flipped so we
end up with the origin in the wrong place.

where do we create this print view?

Comment 8

[saari (gone)]

->pinkerton, last touched, beard on sabbatical

Comment 9

[Ping Liao]

I see this bug on Solaris 8.
Does this bug also occur on Linux and Windows?

Comment 10

[Pete Zha]

I see this problem in trunk(07/15).
The page setup will change back to portrait after print.
But preview is OK for me.

Comment 11

[Greg K.]

Reconfirmed using Chimera/20020718, but WorksForMe using FizzillaCFM/2002071808.

Comment 12

[Jay Yan]

see also bug 145896

Comment 13

[Jay Yan]

I made a mistake in last comment, 
please see bug 147605

Comment 14

[Mike Pinkerton (not reading bugmail)]

-> conrad who seems to like printing bugs

Comment 15

[Conrad Carlen (not reading bugmail)]

The printing code has been reworked quite a bit in recent months - much of it
since the Chimera branch was cut :-/

Comment 16

[Chris Petersen]

*** Bug 165872 has been marked as a duplicate of this bug. ***

Comment 17

[Conrad Carlen (not reading bugmail)]

Not only does the landscape setting not work, *nothing* in the page setup dialog
does. It's because the page setup dialog shown by Chimera (the default Cocoa
one) has nothing to do with Gecko's printing gear so we always print with
default settings. Patch coming up.

Comment 18

[Conrad Carlen (not reading bugmail)]

Attachment: patch

Patch just hooks up page setup menu item to page setup settings that actually
get used.

Comment 19

[Conrad Carlen (not reading bugmail)]

Attachment: resources/localized/English.lproj/MainMenu.nib/objects.nib

binary part of nib file

Comment 20

[Conrad Carlen (not reading bugmail)]

cc'ing Simon.

Comment 21

[Conrad Carlen (not reading bugmail)]

Attachment: better patch

This patch uses a pref, "print.use_global_printsettings", to allow either
global (shared by all windows) or per-window print settings. Note that, until
bug 177573 is fixed, changing the pref in chimera.js has no effect. It must be
changed in all.js.

Looking for review.

Comment 22

[Conrad Carlen (not reading bugmail)]

The default value of "print.use_global_printsettings" is to true in all.js as
well. While it would be nice to fix bug 177573 for its own sake so that all pref
customization could be done in one file, it doesn't really affect this patch.

Comment 23

[Conrad Carlen (not reading bugmail)]

Pink or Simon - Can I get review on this?

Comment 24

[Simon Fraser [no longer active]]

+  
+  nsIPrintSettings*			mPrintSettings;
+  BOOL									mUseGlobalPrintSettings;

Spacing is whacked here. Note that PB inserts tabs if you are not at the start
of the line, irrespective of the prefs.
Please add a comment to say if mPrintSettings is owned (addreffed).

+  nsCOMPtr<nsIInterfaceRequestor> ir(do_QueryInterface(_webBrowser));
+  nsCOMPtr<nsIWebBrowserPrint> print;
+  ir->GetInterface(NS_GET_IID(nsIWebBrowserPrint), getter_AddRefs(print));

Why not do_GetInterface() ?

Otherwise, it looks good. r=sfraser

Comment 25

[Conrad Carlen (not reading bugmail)]

Fixed Simon's issues and checked it in.

Comment 26

[Chris Petersen]

Marking verified in the 2002-11-13-04 NB under 10.2.2. Landscape does print
correctly and scaling the page is functional.

Comment 27

[Chris Petersen]

I found a issue when scaling a page (of less than 44%) will it's content to
disappear on print out. Creating a new bug for that one.

Comment 28

[sairuh (rarely reading bugmail)]

yeah, looks like that's covered by bug 179969.

Comment 29

[Conrad Carlen (not reading bugmail)]

*** Bug 186156 has been marked as a duplicate of this bug. ***