1458977 - Crash in nsFloatManager::ImageShapeInfo::ImageShapeInfo

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-7d63baf7-7cfa-40e4-9407-a60b10180502.
=============================================================

Seen while looking at nightly crash stats - so far very small volume crash hitting Mac and Windows: https://bit.ly/2HN5pta.

looks as if :bradwerth worked in this area in 61, adding ni on him. 

Top 10 frames of crashing thread:

0 xul.dll nsFloatManager::ImageShapeInfo::ImageShapeInfo layout/generic/nsFloatManager.cpp:1693
1 xul.dll mozilla::MakeUnique<nsFloatManager::ImageShapeInfo, unsigned char*&, int&, mozilla::gfx::IntSizeTyped<mozilla::LayoutDevicePixel>&, int&, float&, int&, nsRect&, nsRect&, mozilla::WritingMode&, nsSize const&> mfbt/UniquePtr.h:680
2 xul.dll nsFloatManager::ShapeInfo::CreateImageShape layout/generic/nsFloatManager.cpp:2431
3 xul.dll nsFloatManager::FloatInfo::FloatInfo layout/generic/nsFloatManager.cpp:1975
4 xul.dll nsFloatManager::AddFloat layout/generic/nsFloatManager.cpp:260
5 xul.dll mozilla::BlockReflowInput::FlowAndPlaceFloat layout/generic/BlockReflowInput.cpp:994
6 xul.dll mozilla::BlockReflowInput::PlaceBelowCurrentLineFloats layout/generic/BlockReflowInput.cpp:1083
7 xul.dll nsBlockFrame::PlaceLine layout/generic/nsBlockFrame.cpp:4687
8 xul.dll nsBlockFrame::DoReflowInlineFrames layout/generic/nsBlockFrame.cpp:4086
9 xul.dll nsBlockFrame::ReflowInlineFrames layout/generic/nsBlockFrame.cpp:3832

=============================================================

Comment 1

[Brad Werth [:bradwerth]]

This should be resolved by the patch that landed for Bug 1457288.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

No reports since bug 1457288 landed, which is good enough for me to say it's fixed.