1459052 - async-scene-building: https://codepen.io/YusukeNakaya/pen/ZXmJjj doesn't react

Status: RESOLVED DUPLICATE of bug 1458177

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

https://codepen.io/YusukeNakaya/pen/ZXmJjj

Hover it. Nothing happens.
Fixed by disabling gfx.webrender.async-scene-build.

(I'll file another bug about the clipping issue.)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I can reproduce on mac. It looks like it doesn't update at all, regardless of mouse movement. However I ran it in a profile with TreeStyleTabs installed and as I moused over the tabs in the sidebar (which triggers repaints) I could see the visual effect update... but not correctly. It looked like there were a set of images that it was cycling through, or something. I'll try to attach a video.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Video

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Seems to be behaving much better now, but still seems a little jumpy.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I bisected the improvement:

./mach mozregression --find-fix --bad 2018-05-04 --persist ~/Downloads/mozregression/ --pref gfx.webrender.all:true -a https://codepen.io/YusukeNakaya/pen/ZXmJjj

produced: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=754824066ed075a0654efdf1ce381bf3660ed650&tochange=86732dd98df09741b53c037f32620e80b007b6bd

So the WR update in bug 1458870 helped somehow.

Comment 5

[Aria Beingessner [:Gankra]]

It strikes me as likely that this is a dupe of https://bugzilla.mozilla.org/show_bug.cgi?id=1455591, since the underlying issue is cached pictures (things like blurs) getting picked up from old frames inappropriately.

Comment 6

[Aria Beingessner [:Gankra]]

Sorry, meant to link https://bugzilla.mozilla.org/show_bug.cgi?id=1458177

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Yeah I suspected that might be the case. We can retest once we have builds with that fix.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Latest try push on bug 1466549 does seem to not have this problem, so we can close this once that merges.

Comment 9

[Darkspirit]

Fix range: https://github.com/servo/webrender/compare/8e697f8cb1f1aab2e5f6b9b903eb7191340b10c5...952521658aaf331e7b7382fb18ca1d8b7bfc9dc8

Thanks!