1459140 - [wpt-sync] Sync PR 10840 - [Resource-Timing] Fix `initiatorType` values

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 10840 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10840
Details from upstream follow.

Yoav Weiss <[e-mail]> wrote:
>  [Resource-Timing] Fix `initiatorType` values
>  
>  There were multiple issues with current `initiatorType` implementation:
>  * `fetch()` resources had an empty value instead of "fetch"
>  * `<video>` resources had an empty value instead of "video"
>  * `<audio>` resources had an empty value instead of "audio"
>  * `<track>` resources had "texttrack" value instead of "track"
>  * EventSource resources had an empty value instead of "other"
>  
>  On top of that, the test to make sure the above is all in check had
>  some values that were not aligned to the spec, and was disabled due to
>  the flakiness of audio and video loads.
>  
>  This CL fixes the above values, fixes the test to be more spec
>  compliant and enables it.
>  
>  Bug: 649571, 822757
>  Change-Id: I1dc6fd35e5e4bc570cbbb7d743dc02279bf42b8b
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1040925
>  WPT-Export-Revision: b143db158fa7204c3720dc8e47d5fbdbdf2ebb7a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4efa628e61d71ddc70b464a740205f8c864bb766

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=14bcd885225881bb15e1b9e02b4d2a4faeb467d8

Comment 3

[Yoav Weiss]

This test was flaky in Firefox before this PR's test change. Testing it locally in its pre-PR form, I see a different number of failures on each run.

It seems like some resource types are not consistently loaded, or at least not consistently reported. The ones I noticed were the video resources as well as the `<link rel=prefetch>` resource.

The test in question is https://wpt.fyi/results/resource-timing/resource_initiator_types.html
I'm attaching the entire current directory, as it's needed to reproduce the issue (and to make sure this is still reproducible despite future changes to the test).

Comment 4

[Yoav Weiss]

Attachment: resource-timing.tar.gz

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e12e162b54c9c7c9309523d651cbfae197106d14

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e82e5888e21e97cfe08b627756d654aa2207ab66

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 36 subtests
OK     : 1
PASS   : 22
FAIL   : 14

New tests that have failures or other problems:
/resource-timing/resource_initiator_types.html
    http://web-platform.test:8000/media/test.mp4?id=video-source is expected to have initiatorType video: FAIL
    http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-mpeg is expected to have initiatorType audio: FAIL
    http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-ogg is expected to have initiatorType audio: FAIL
    http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-wav is expected to have initiatorType audio: FAIL

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b029276297d9
[wpt PR 10840] - [Resource-Timing] Fix `initiatorType` values, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/339c9de0e6ef
[wpt PR 10840] - Update wpt metadata, a=testonly

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b029276297d9
https://hg.mozilla.org/mozilla-central/rev/339c9de0e6ef