1459181 - mozapkpublisher doesn't fetch "whatsnew" section of the correct version

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

In [1], :flod added a new API endpoint so that store_l10n expose version-specific "whatsnew" section. We haven't used it in mozapkpubliser yet. As a consequence, we pushed Fennec 60.0RC with the "whatsnew" of Firefox 59.0.

:jcristau manually fixed it by copy and pasting the whatsnew field from beta to release. This was easy enough because only one field needed to be copied/pasted. However, this represents an extra-manual step and a risk if the host computer doesn't have encoding correctly configured. Let's fix this for real.

https://github.com/mozilla-l10n/stores_l10n/issues/160

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #0)
> In [1], :flod added a new API endpoint so that store_l10n expose
> version-specific "whatsnew" section. We haven't used it in mozapkpubliser
> yet. As a consequence, we pushed Fennec 60.0RC with the "whatsnew" of
> Firefox 59.0.

Note that we don't have content for 60 yet, and possibly won't have before release at this point.

And there's an ongoing thread about stopping to do it all together.

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> (In reply to Johan Lorenzo [:jlorenzo] from comment #0)
> > In [1], :flod added a new API endpoint so that store_l10n expose
> > version-specific "whatsnew" section. We haven't used it in mozapkpubliser
> > yet. As a consequence, we pushed Fennec 60.0RC with the "whatsnew" of
> > Firefox 59.0.
> 
> Note that we don't have content for 60 yet, and possibly won't have before
> release at this point.

Never mind, Friday brain. We don't have content for 61 yet, 60 is there from the past Beta cycle.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1459181 - Fetch version-specific "whatsnew" on mozilla-release only

Review commit: https://reviewboard.mozilla.org/r/241702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241702/

Comment 4

[Simon Fraser [:sfraser] ⌚️GMT]

Comment on attachment 8973214 [details]
Bug 1459181 - Fetch version-specific "whatsnew" on mozilla-release only

https://reviewboard.mozilla.org/r/241702/#review247530

Comment 5

[Johan Lorenzo [:jlorenzo]]

Attachment: [mozapkpublisher] get_l10n_strings: fetch version-specific "whatsnew" section if provided

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1459181 - Bump pushapkscript and mozapkpublisher

Review commit: https://reviewboard.mozilla.org/r/241718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241718/

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 8973235 [details]
Bug 1459181 - Bump pushapkscript and mozapkpublisher

https://reviewboard.mozilla.org/r/241718/#review247596

Comment 8

[Johan Lorenzo [:jlorenzo]]

Please deploy these changes if you need to respin a new Fennec RC. Otherwise, I'll land them in 10 days from now.

Comment 9

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8973235 [details]
Bug 1459181 - Bump pushapkscript and mozapkpublisher

This is not needed anymore thanks to bug 1409091:
* https://hg.mozilla.org/build/puppet/rev/1319f9406ee2#l3.13
* https://hg.mozilla.org/build/puppet/rev/1319f9406ee2#l3.44

Comment 10

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8973227 [details] [review]
[mozapkpublisher] get_l10n_strings: fetch version-specific "whatsnew" section if provided

Landed on master at https://github.com/mozilla-releng/mozapkpublisher/commit/50750fceb7c0d831cf61cb550af62b2c93e8e755
Released as part of mozapkpublisher 0.7.2:
* https://github.com/mozilla-releng/mozapkpublisher/releases/tag/0.7.2
* https://pypi.python.org/pypi/mozapkpublisher/0.7.2

Comment 11

[Johan Lorenzo [:jlorenzo]]

This requires a newer version of the google-play-strings image which is handled in bug 1459980.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc805cf0e6c5
Fetch version-specific "whatsnew" on mozilla-release only r=sfraser

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bc805cf0e6c5

Comment 14

[Johan Lorenzo [:jlorenzo]]

Landed on beta at https://hg.mozilla.org/releases/mozilla-beta/rev/fac7359cd0ada8b6ae5fd5a61854793444f76bf6