Closed
Bug 1459193
Opened 7 years ago
Closed 7 years ago
Arcanist should translate public commit sha to hg
Categories
(Conduit :: Phabricator, enhancement)
Conduit
Phabricator
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zalun, Assigned: zalun)
References
Details
(Keywords: conduit-triaged)
Attachments
(1 file)
Currently diffs might be created from git-cinnabar repositories. Diff's base of shuch a commit would have a git sha. This would be problematic for developers who don't have git-cinnabar installed. We should be translating the sha to hg before creating the diff.
|
||
Comment 1•7 years ago
|
||
Solution proposed in https://admin.phacility.com/PHI572 enhanced with an ability
to work when the diff's base commit is not public (checking for '00..' as a
result of h2git or git2hg).
Checked with `arc diff` and `arc patch` commands.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → pzalewa
|
|
||
Updated•7 years ago
|
Attachment #8973206 -
Attachment description: WIP using git-cinnabar in Arcanist → cinnabar: using git-cinnabar in Arcanist
|
|
||
Updated•7 years ago
|
Keywords: conduit-triaged
|
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8973206 [details]
cinnabar: using git-cinnabar in Arcanist
Steven MacLeod [:smacleod] has approved the revision.
https://phabricator.services.mozilla.com/D1034
Attachment #8973206 -
Flags: review+
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•