1459302 - Generate buildhub.json for l10n repacks

Status: RESOLVED WONTFIX

(Firefox Build System :: General, enhancement)

Description

[(not currently active) Ted Mielczarek]

bug 1442306 added code to generate a buildhub.json file during packaging. Unfortunately it doesn't work for l10n repacks, which is something we do want. I'm splitting this off to a separate bug so I can land the patches on that bug.

Comment 1

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a952dff86ce5f046ea343773864b34c43329a22

Comment 2

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=abdcc6fb7d134ee95002f50e9e8b3fcab1cd2b89

Comment 3

[Peter Bengtsson [:peterbe]]

Pardon intrusion, but can I ask what the status of this is. 
In https://bugzilla.mozilla.org/show_bug.cgi?id=1443873 we're waiting for Mihai to wrap up the work of fixing the download.url and making sure the actual buildhub.json file gets uploaded. 

Is there anything I can do to help on this bug?

Comment 4

[Lisa Guo [:lguo] EST]

I noticed Mihai's update, is buildhub.json now being generated for l10n repacks?

Comment 5

[Peter Bengtsson [:peterbe]]

Any progress on this on Ted?

Comment 6

[(not currently active) Ted Mielczarek]

I went around and around on this a few times and couldn't figure out a reasonable place to put this (seemingly simple) logic in the rat's nest that is our l10n repack setup. I know this is blocking useful work on the buildhub side so I talked to Callek today about a potential implementation and he seemed OK with it.

We currently have `EN_US_BINARY_URL` defined to point to the en-US package in l10n repack tasks:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/taskcluster/ci/l10n/kind.yml#108

We could similarly define an `EN_US_BUILDHUB_URL` there to point to the en-US buildhub.json.

Then we would fetch that buildhub.json file when we fetch the en-US package:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/scripts/desktop_l10n.py#353

I'd just do it directly in the mozharness Python instead of trying to wire it into the build system. Then, somewhere in the `make_upload` function in the mozharness script we'd read the en-US buildhub.json and update the target.locale and download.* keys that differ from en-US:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/scripts/desktop_l10n.py#444-502

The only finicky bit there would be determining the installer/package filename, since mozharness and the build system are kind of at arm's length here. I think that much is manageable though.

Comment 7

[Justin Wood (:Callek)]

Ben, since we're starting to own buildhub stuff, do you know anything about this and if its still wanted/needed?

Comment 8

[[e-mail] (:bhearsum)]

I did some digging and most (all?) of the stakeholders have weighed in on https://github.com/mozilla-releng/buildhub2/issues/477 and are OK with not having l10n data. Let's close this as WONTFIX, and we'll re-open if needed.