1459352 - mixed content blocking warning is displayed as gray on the dark theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[(no longer active)]

Attachment: mixed-content-blocking.png

Please see the screenshot attached, captured on aurora.

Comment 1

[(no longer active)]

Attachment: mixed-content-blocking.png

BTW if you click on the "Show connection details" arrow, the other mixed content blocking text is also displayed as gray.

Comment 2

[Johann Hofmann [:johannh]]

So we're using Graytext all over the identity popup, but I agree it's a bit dark on the dark theme. Does anyone know a good cross-theme alternative to Graytext for the identity popup or do we need to special-case dark theme here? Would also be interesting for bug 1457512 in which it's planned to make more sections gray...

Comment 3

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #2)
> Does anyone know a good cross-theme alternative to
> Graytext for the identity popup or do we need to special-case dark theme
> here?

--autocomplete-popup-secondary-color could be renamed and moved from ThemeVariableMap.jsm to LightweightThemeConsumer.jsm to be available for all popups.

Comment 4

[Dão Gottwald [:dao]]

Bug 1462635 did not fix this.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1459352 - Fix disabled text color in webext theme styled control center.

Review commit: https://reviewboard.mozilla.org/r/247104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247104/

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 8980953 [details]
Bug 1459352 - Fix disabled text color in webext theme styled control center.

https://reviewboard.mozilla.org/r/247104/#review253178

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ca472c1e19a
Fix disabled text color in webext theme styled control center. r=ntim

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9ca472c1e19a

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9ca472c1e19a

Comment 10

[Tim Nguyen :ntim]

Comment on attachment 8980953 [details]
Bug 1459352 - Fix disabled text color in webext theme styled control center.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1408121
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no, css change not covered by tests
[Has the fix been verified in Nightly?]: 
[Needs manual test from QE? If yes, steps to reproduce]: see comment 0
[List of other uplifts needed for the feature/fix]: bug 1462635 (which was just uplifted)
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: css only
[String changes made/needed]: n/a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8980953 [details]
Bug 1459352 - Fix disabled text color in webext theme styled control center.

Fix for difficult to see text with the dark theme. Approved for 61.0b9.

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/17fdd7dd7ba3

Comment 13

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 x64, Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13 using Firefox 61 Beta 9 (buildID: 20180528091514) and latest Nightly 62.0a1 (2018-05-29).