mixed content blocking warning is displayed as gray on the dark theme

VERIFIED FIXED in Firefox 61

Status

()

defect
P2
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: Ehsan, Assigned: dao)

Tracking

({regression})

unspecified
Firefox 62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 verified, firefox62 verified)

Details

Attachments

(3 attachments)

Reporter

Description

a year ago
Please see the screenshot attached, captured on aurora.
Reporter

Comment 1

a year ago
BTW if you click on the "Show connection details" arrow, the other mixed content blocking text is also displayed as gray.
So we're using Graytext all over the identity popup, but I agree it's a bit dark on the dark theme. Does anyone know a good cross-theme alternative to Graytext for the identity popup or do we need to special-case dark theme here? Would also be interesting for bug 1457512 in which it's planned to make more sections gray...
Assignee

Comment 3

a year ago
(In reply to Johann Hofmann [:johannh] from comment #2)
> Does anyone know a good cross-theme alternative to
> Graytext for the identity popup or do we need to special-case dark theme
> here?

--autocomplete-popup-secondary-color could be renamed and moved from ThemeVariableMap.jsm to LightweightThemeConsumer.jsm to be available for all popups.
Blocks: 1408121
Priority: -- → P2
Assignee

Updated

a year ago
Depends on: 1462635

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1462635]
Target Milestone: --- → Firefox 62
Assignee

Comment 4

a year ago
Bug 1462635 did not fix this.
Assignee: nobody → dao+bmo
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [fixed by bug 1462635]
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8980953 [details]
Bug 1459352 - Fix disabled text color in webext theme styled control center.

https://reviewboard.mozilla.org/r/247104/#review253178
Attachment #8980953 - Flags: review?(ntim.bugs) → review+

Comment 7

a year ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9ca472c1e19a
Fix disabled text color in webext theme styled control center. r=ntim

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ca472c1e19a
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
Assignee

Updated

a year ago
Comment on attachment 8980953 [details]
Bug 1459352 - Fix disabled text color in webext theme styled control center.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1408121
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no, css change not covered by tests
[Has the fix been verified in Nightly?]: 
[Needs manual test from QE? If yes, steps to reproduce]: see comment 0
[List of other uplifts needed for the feature/fix]: bug 1462635 (which was just uplifted)
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: css only
[String changes made/needed]: n/a
Attachment #8980953 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Comment on attachment 8980953 [details]
Bug 1459352 - Fix disabled text color in webext theme styled control center.

Fix for difficult to see text with the dark theme. Approved for 61.0b9.
Attachment #8980953 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed on Windows 7 x64, Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13 using Firefox 61 Beta 9 (buildID: 20180528091514) and latest Nightly 62.0a1 (2018-05-29).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.