Closed Bug 1459354 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 10857 - WaveShaper must output non-zero values even if input is silent

Categories

(Core :: Web Audio, enhancement, P4)

Product:
Core
Component:
Web Audio
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 10857 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10857
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:
>  WaveShaper must output non-zero values even if input is silent
>  
>  If the curve for the WaveShaperNode is such that a zero input produces
>  a non-zero output, the WaveShaperNode needs to output that value even
>  if the input is silent (or disconnected).
>  
>  Do this by setting the tail time of the processor to 0 or infinity
>  depending on whether the curve specifies an output value of zero or
>  not, respectively.
>  
>  Bug: 807301
>  Test: WaveShaper/silent-inputs.html
>  Change-Id: I6539d2e00f5d3e624ffaf2810944eb6d53d6f84b
>  Reviewed-on: https://chromium-review.googlesource.com/896266
>  WPT-Export-Revision: 6802cf00cdb43cb4fb69f8801b85f9b1b29404c6
Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 1 tests and 11 subtests
OK     : 1
PASS   : 4
FAIL   : 7

New tests that have failures or other problems:
/webaudio/the-audio-api/the-waveshapernode-interface/silent-inputs.html
    # AUDIT TASK RUNNER FINISHED: 3 out of 3 tasks were failed.: FAIL
    < [test-0] 1 out of 1 assertions were failed.: FAIL
    < [test-1] 1 out of 1 assertions were failed.: FAIL
    < [test-2] 1 out of 1 assertions were failed.: FAIL
    X WaveShaper with 2x oversample, silent inputs, and curve {"0":0.5,"1":0.5,"2":0.5}: Expected 0.5 for all values but found 16000 unexpected values: 
	Index	Actual
	[0]	0
	[1]	0
	[2]	0
	[3]	0
	...and 15996 more errors.: FAIL
    X WaveShaper with no inputs and curve {"0":0.5,"1":0.5,"2":0.5}: Expected 0.5 for all values but found 16000 unexpected values: 
	Index	Actual
	[0]	0
	[1]	0
	[2]	0
	[3]	0
	...and 15996 more errors.: FAIL
    X WaveShaper with silent inputs and curve {"0":0.5,"1":0.5,"2":0.5}: Expected 0.5 for all values but found 16000 unexpected values: 
	Index	Actual
	[0]	0
	[1]	0
	[2]	0
	[3]	0
	...and 15996 more errors.: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/168b53cc7982
[wpt PR 10857] - WaveShaper must output non-zero values even if input is silent, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c49cfec2e80
[wpt PR 10857] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/19214723eb55
[wpt PR 10857] - WaveShaper must output non-zero values even if input is silent, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/df584a35ba76
[wpt PR 10857] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/19214723eb55
https://hg.mozilla.org/mozilla-central/rev/df584a35ba76
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.