1459433 - We should figure out a way to get fakeauth from tc-lib-testing to not hardcode taskcluster.net

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Description

[Brian Stack [:bstack]]

Currently this is the most obvious place I can find in testing where we hardcode taskcluster.net. 

I haven't thought this through very hard yet. Perhaps we should just change this to be a tracker bug for removing hardcoded tc.net everywhere in tests? Feel free to rename/reassign if so.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

What if we invented a universally-observed "fake" rootUrl for testing?  `https://tc-tests.localhost` perhaps?  Then fakeauth could fake that with nock, for example.

Comment 2

[Brian Stack [:bstack]]

++ I support that plan. Perhaps we can even make this a thing on tc-lib-urls?

```
const tcUrl = require('taskcluster-lib-urls');
tcUrl.testRootUrl(); // Or some better name.
```

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

I like it!

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-lib-urls/pull/1 fixes this, I think?

Comment 5

[Brian Stack [:bstack]]

We still need to updated tc-lib-testing, right?

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

WIP at https://github.com/taskcluster/taskcluster-lib-testing/compare/master...djmitche:bug1459433?expand=1 but I need tc-lib-api updates before I can test that.

Comment 7

[Brian Stack [:bstack]]

Just landed. Sorry for delay, taking the training today.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

It's bug 1460026 that needs to land first, I think.

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-lib-testing

https://github.com/taskcluster/taskcluster-lib-testing/commit/d30f13e6aa6d293cd2178aca75bca166eaa2e572
Redeployability Great Library Update - 10.0 (#27)

Updates to support redeployability

* Bug 1459433 - remove babel
* Bug 1459433 - make fakeauth fake a specified rootUrl
* Bug 1459433 - require node > 8
* Bug 1459433 - upgrade to the latest taskcluster-client, but fetch secrets with superagent since taskcluster-proxy does not present as a rootUrl
* Bug 1459433 - pass apis, not routers, to tc-lib-app

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Done!