Allow changing the tab separator color

VERIFIED FIXED in Firefox 62

Status

defect
P1
normal
VERIFIED FIXED
a year ago
10 months ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

(Blocks 1 bug, {dev-doc-complete})

unspecified
mozilla62
Dependency tree / graph

Firefox Tracking Flags

(firefox62 verified, firefox63 verified)

Details

Attachments

(2 attachments)

Assignee

Description

a year ago
No description provided.
Comment hidden (mozreview-request)
Assignee: nobody → ntim.bugs
Priority: -- → P1
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8973547 [details]
Bug 1459455 - Allow changing the tab separator color.

https://reviewboard.mozilla.org/r/241904/#review253782

::: toolkit/components/extensions/test/browser/browser_ext_themes_tab_separators.js:12
(Diff revision 3)
> +  let extension = ExtensionTestUtils.loadExtension({
> +    manifest: {
> +      "theme": {
> +        "colors": {
> +          "accentcolor": "#000",
> +          "textcolor": TAB_TEXT_COLOR,

TAB_TEXT_COLOR isn't referenced anywhere else so we should remove this constant so the test is easier to follow. Right now it gives the appearance that this constant may be referenced at another place within the test.
Attachment #8973547 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)

Comment 6

a year ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c6bd6395abb7
Allow changing the tab separator color. r=jaws
Comment hidden (mozreview-request)

Comment 9

a year ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/16f1a4771b09
Allow changing the tab separator color. r=jaws

Comment 10

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d67e33e20cbd
Revert accidentally-landed package-lock.json changes.
Assignee

Updated

a year ago
Flags: needinfo?(ntim.bugs)
Keywords: dev-doc-needed

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/16f1a4771b09
https://hg.mozilla.org/mozilla-central/rev/d67e33e20cbd
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62

Updated

11 months ago
Product: Toolkit → WebExtensions

Comment 12

11 months ago
Added code example and image to https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme and updated the browser compatibility information. PR: https://github.com/mdn/browser-compat-data/pull/2349
Can we get a review on the docs change in c#12?

Also, Irene, remember to add an entry to the Fx62 rel notes to report this change: 
https://developer.mozilla.org/en-US/Firefox/Releases/62

Thanks both!
Flags: needinfo?(ntim.bugs)
Assignee

Comment 14

11 months ago
(In reply to Irene Smith from comment #12)
> Added code example and image to
> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/
> theme and updated the browser compatibility information. PR:
> https://github.com/mdn/browser-compat-data/pull/2349

Looks great, thanks Irene!
Flags: needinfo?(ntim.bugs)

Comment 15

11 months ago
Posted image Bug1459455.png
This issue is verified as fixed on Firefox 63.0a1 (20180709221247) and Firefox 62.0b7 (20180709172241) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached screenshot.

Updated

11 months ago
Status: RESOLVED → VERIFIED

Updated

10 months ago
You need to log in before you can comment on or make changes to this bug.