1459455 - Allow changing the tab separator color

Status: VERIFIED FIXED

(WebExtensions :: Themes, defect, P1)

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1459455 - Allow changing the tab separator color.

Review commit: https://reviewboard.mozilla.org/r/241904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241904/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8973547 [details]
Bug 1459455 - Allow changing the tab separator color.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241904/diff/1-2/

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8973547 [details]
Bug 1459455 - Allow changing the tab separator color.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241904/diff/2-3/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8973547 [details]
Bug 1459455 - Allow changing the tab separator color.

https://reviewboard.mozilla.org/r/241904/#review253782

::: toolkit/components/extensions/test/browser/browser_ext_themes_tab_separators.js:12
(Diff revision 3)
> +  let extension = ExtensionTestUtils.loadExtension({
> +    manifest: {
> +      "theme": {
> +        "colors": {
> +          "accentcolor": "#000",
> +          "textcolor": TAB_TEXT_COLOR,

TAB_TEXT_COLOR isn't referenced anywhere else so we should remove this constant so the test is easier to follow. Right now it gives the appearance that this constant may be referenced at another place within the test.

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8973547 [details]
Bug 1459455 - Allow changing the tab separator color.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241904/diff/3-4/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6bd6395abb7
Allow changing the tab separator color. r=jaws

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out changeset c6bd6395abb7 (bug 1459455) for ESlint failure on browser_ext_themes_tab_separators.js

Backout: https://hg.mozilla.org/integration/autoland/rev/064204d6d6d9a23a813e05839e94ab92f949328b

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c6bd6395abb7548670943c86291c669a0959889d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&filter-classifiedState=unclassified&selectedJob=180796189

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=180796189&repo=autoland&lineNumber=257

Comment 8

[Tim Nguyen :ntim]

Comment on attachment 8973547 [details]
Bug 1459455 - Allow changing the tab separator color.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241904/diff/4-5/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16f1a4771b09
Allow changing the tab separator color. r=jaws

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d67e33e20cbd
Revert accidentally-landed package-lock.json changes.

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/16f1a4771b09
https://hg.mozilla.org/mozilla-central/rev/d67e33e20cbd

Comment 12

[Irene Smith]

Added code example and image to https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme and updated the browser compatibility information. PR: https://github.com/mdn/browser-compat-data/pull/2349

Comment 13

[Chris Mills [:cmills]]

Can we get a review on the docs change in c#12?

Also, Irene, remember to add an entry to the Fx62 rel notes to report this change: 
https://developer.mozilla.org/en-US/Firefox/Releases/62

Thanks both!

Comment 14

[Tim Nguyen :ntim]

(In reply to Irene Smith from comment #12)
> Added code example and image to
> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/
> theme and updated the browser compatibility information. PR:
> https://github.com/mdn/browser-compat-data/pull/2349

Looks great, thanks Irene!

Comment 15

[CosminB]

Attachment: Bug1459455.png

This issue is verified as fixed on Firefox 63.0a1 (20180709221247) and Firefox 62.0b7 (20180709172241) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached screenshot.