Closed Bug 1459513 Opened Last year Closed Last year

Crash in java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference at org.mozilla.gecko.webapps.WebAppManifest.isInScope(WebAppManifest.java)

Categories

(Firefox for Android :: Web Apps, defect, critical)

Firefox 58
Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- verified
firefox62 --- fixed

People

(Reporter: philipp, Assigned: droeh)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file, 1 obsolete file)

This bug was filed from the Socorro interface and is
report bp-850fd4e7-26ac-4232-ac87-3e1c80180506.
=============================================================

Java Stack Trace 	

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference
	at org.mozilla.gecko.webapps.WebAppManifest.isInScope(WebAppManifest.java:228)
	at org.mozilla.gecko.webapps.WebAppActivity.onLoadRequest(WebAppActivity.java:382)
	at org.mozilla.geckoview.GeckoSession$2.handleMessage(GeckoSession.java:167)
	at org.mozilla.geckoview.GeckoSession$2.handleMessage(GeckoSession.java:139)
	at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:105)
	at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:337)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6692)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1468)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358)

=============================================================

this signature is showing up in crash reports from fennec 58 and later. many user comments talk about  pinning google+ to the homescreen and following links from there, like for example at bp-08ad6960-d1a9-490d-bc27-d80f00180127
Assignee: nobody → droeh
Attachment #8975165 - Flags: review?(snorp)
Minor fix to original patch.
Attachment #8975165 - Attachment is obsolete: true
Attachment #8975165 - Flags: review?(snorp)
Attachment #8975170 - Flags: review?(snorp)
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0a5c38cfff2
Handle null uri components gracefully in WebAppManifest. r=snorp
https://hg.mozilla.org/mozilla-central/rev/b0a5c38cfff2
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Please request Beta approval on this when you get a chance.
Flags: needinfo?(droeh)
Comment on attachment 8975170 [details] [diff] [review]
Handle null uri components in WebAppManifest

Approval Request Comment
[Feature/Bug causing the regression]: bug 1353868
[User impact if declined]: Crashes in the Google+ PWA and possibly other PWAs
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Probably not.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Effectively just checks for a possible null pointer
[String changes made/needed]: None
Flags: needinfo?(droeh)
Attachment #8975170 - Flags: approval-mozilla-beta?
Comment on attachment 8975170 [details] [diff] [review]
Handle null uri components in WebAppManifest

Add a null check to avoid a Fennec crash. Approved for 61.0b7.
Attachment #8975170 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
We tested on 61.0b7 with Nexus 5(Android 6.0.1), Samsung Galaxy Note 8(Android 8.0), Xiaomi Mi4i (Android 5.0.2), OnePlus 5T(Android 8.0) with Google+ and others PWAs and we didn't encounter any crash.
You need to log in before you can comment on or make changes to this bug.