1459563 - page number field in print preview dialog is too wide

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P3)

Description

[:aceman]

In print preview dialog, the current page number field is too wide now (from what it was before 60). It now has space for about 10 digits (insane for number of print pages), while it was 3-4 before.
Possibly caused by bug 1429573 too and not fixed by bug 1437302. It is still seen in Firefox nightly.
Also seen in Thunderbird as the dialog is shared.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey aceman, is this Linux only? I'm not able to see the issue on Windows (https://imgur.com/dLOiJde)

Comment 2

[Julien Cristau [:jcristau]]

Seeing this on linux too FWIW, https://people.debian.org/~jcristau/fx-print-preview.png

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Tentatively marking this as Linux-only. Please re-set if anybody is seeing this on Windows too.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hey paolo, could this be fallout from bug 1429573 / bug 1437302, as aceman suggests?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug1459563.patch

Bug 1437302 didn't set the width of this field on Linux, only for Windows.

I added 3ch more because the linux uses wider borders than Windows.

Aceman, can you try this patch as Mike probably has no Linux.

Comment 6

[:aceman]

Comment on attachment 8973745 [details] [diff] [review]
Bug1459563.patch

Review of attachment 8973745 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this works for me. There is now space exactly for 3 digits.

Comment 7

[Jorg K (CEST = GMT+2)]

Julien, are you sure that you don't want to fix FF 60 ESR with a simple CSS tweak? No risk, and it looks bad in a version that will live for a year.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8973745 [details] [diff] [review]
Bug1459563.patch

Yes, this looks much better. Thanks, Paenglab!

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Bug1459563.patch

This one calculated the field width with the padding on each side and a border of 6px (this depends on the Linux theme but most use 6px).

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8973793 [details] [diff] [review]
Bug1459563.patch

LGTM, thanks!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b006cfda5d9e
Set also on Linux a width of the page number field in print preview dialog. r=mconley

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 8973793 [details] [diff] [review]
Bug1459563.patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1429573 
[User impact if declined]: Ugly page number field in print preview
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: No.
[Is the change risky?]: Not risky, just a few lines of CSS defining a width for the field.
[Why is the change risky/not risky?]: See above.
[String changes made/needed]: None.

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b006cfda5d9e

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8973793 [details] [diff] [review]
Bug1459563.patch

Simple CSS fix, approved for 61.0b4. We'll look at the ESR60 request later in the cycle.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5dcb2fb14d89

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 8973793 [details] [diff] [review]
Bug1459563.patch

fix print preview regression in 60.1esr

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/65d0f71da240