Open Bug 1459567 Opened 3 years ago Updated 4 months ago

Remove unnecessary generators from devtools codebase

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: ystartsev, Unassigned)

References

(Blocks 1 open bug)

Details

Since the Task.async refactoring, we have a number of places where we should re-evaluate the use of generators. Full list of generator usage: https://searchfox.org/mozilla-central/search?q=function*&case=true&regexp=false&path=%5Edevtools

Areas we should focus on or check:

- Dispatch calls that use generators, such as https://searchfox.org/mozilla-central/source/devtools/client/memory/actions/filter.js#25
- Sourcemaps translation of async to generators -> perhaps we can avoid this transformation
- unnecessary generators such as https://searchfox.org/mozilla-central/source/devtools/server/tests/browser/storage-unsecured-iframe.html#19
- updates to docs such as https://searchfox.org/mozilla-central/source/devtools/docs/tests/writing-tests.md#46 and https://searchfox.org/mozilla-central/source/devtools/client/inspector/shared/test/head.js#42
- checking tests that might potentially be broken and failing silently such as https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/test/test_commands_other.html#38 and https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/test/common.js#228-242
Priority: -- → P3
Product: Firefox → DevTools
Depends on: 1674986
Assignee: ystartsev → nobody
You need to log in before you can comment on or make changes to this bug.