145968 - CSS parser accepts unknown pseudo-classes/elements

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The CSS parser accepts unknown pseudo-classes/elements in violation of the CSS
forward-compatible parsing rules.

A proposed solution:
 * Split nsCSSAtomList into nsCSSPseudoClassList, nsCSSPseudoElementList, and
nsCSSGlobalPseudoList (for the things I described as -moz-special in bug 144826).
 * Give these atom lists a lookup method as well.

(The latter distinction would be useful for changes in ReResolveStyleContext,
since it should skip over the "global pseudos".  See bug 141054 comment 18.)

Comment 1

[Hixie (not reading bugmail)]

When you say "accepts" what do you mean?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Doesn't throw away the entire rule.

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Absolutely true

Comment 4

[Hixie (not reading bugmail)]

righto. http://www.hixie.ch/tests/adhoc/css/selectors/parsing/001.xml

Comment 5

[Boris Zbarsky [:bzbarsky]]

Hmm... so if any selector in a comma-separated list of selectors is not
recognized the entire rule is to be tossed?   where is this referenced?

The reason I ask is that a selector like

foo:ugh, bar

is obviously "(foo with a pseudo-class of ugh) or (bar)" and it seems to me that
style could be applied to things matching (bar) even per FC requirements?

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Does that extend to

foo:ugh(1), bar
foo:ugh(1, {color: red}), bar

?

Third paragraph of:
http://www.w3.org/TR/REC-CSS2/syndata.html#q8

Comment 7

[Boris Zbarsky [:bzbarsky]]

Ah, excellent, fourth paragraph.  I wish this were in section 4.2 as well.  ;)

Thank you.

Comment 8

[Madhur Bhatia]

Attachment: Ian's testcase ....

.... provided in comment 4 attached directly to bugzilla.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed by patch in bug 62843.

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

One website this broke is described in bug 220986.

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

*** Bug 223122 has been marked as a duplicate of this bug. ***