Status

task
RESOLVED FIXED
Last year
6 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

3 Branch
mozilla62
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(8 attachments)

Assignee

Description

Last year
Filing a bug to hold code reviews for patches I've already written.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

Last year
mozreview-review
Comment on attachment 8973832 [details]
Bug 1459737 - Move run-task into taskcluster/scripts;

https://reviewboard.mozilla.org/r/242194/#review248232
Attachment #8973832 - Flags: review?(dustin) → review+

Comment 10

Last year
mozreview-review
Comment on attachment 8973833 [details]
Bug 1459737 - Make run-task more runnable on non-POSIX platforms;

https://reviewboard.mozilla.org/r/242196/#review248236
Attachment #8973833 - Flags: review?(dustin) → review+

Comment 11

Last year
mozreview-review
Comment on attachment 8973834 [details]
Bug 1459737 - Teach run-task where to find Mercurial on Windows;

https://reviewboard.mozilla.org/r/242198/#review248238
Attachment #8973834 - Flags: review?(dustin) → review+

Comment 12

Last year
mozreview-review
Comment on attachment 8973835 [details]
Bug 1459737 - Move closure to module-level function;

https://reviewboard.mozilla.org/r/242200/#review248242
Attachment #8973835 - Flags: review?(dustin) → review+

Comment 13

Last year
mozreview-review
Comment on attachment 8973836 [details]
Bug 1459737 - Require to run on root on POSIX platforms;

https://reviewboard.mozilla.org/r/242202/#review248246
Attachment #8973836 - Flags: review?(dustin) → review+

Comment 14

Last year
mozreview-review
Comment on attachment 8973837 [details]
Bug 1459737 - Move cache configuration to standalone function;

https://reviewboard.mozilla.org/r/242204/#review248268
Attachment #8973837 - Flags: review?(dustin) → review+

Comment 15

Last year
mozreview-review
Comment on attachment 8973838 [details]
Bug 1459737 - Move volume configuration to standalone function;

https://reviewboard.mozilla.org/r/242206/#review248270

::: taskcluster/scripts/run-task:350
(Diff revision 1)
> +        sys.exit(1)
> +
> +    # The volume is almost certainly owned by root:root. Chown it so it
> +    # is writable.
> +
> +    if running_as_root:

aren't we always running as root now?
Attachment #8973838 - Flags: review?(dustin) → review+

Comment 16

Last year
mozreview-review
Comment on attachment 8973839 [details]
Bug 1459737 - Assert that volumes aren't used on Windows;

https://reviewboard.mozilla.org/r/242208/#review248272
Attachment #8973839 - Flags: review?(dustin) → review+
Assignee

Comment 17

Last year
mozreview-review-reply
Comment on attachment 8973838 [details]
Bug 1459737 - Move volume configuration to standalone function;

https://reviewboard.mozilla.org/r/242206/#review248270

> aren't we always running as root now?

Yes. Old habits die hard, I suppose. I'll submit a minor fixup.
Assignee

Comment 18

Last year
mozreview-review-reply
Comment on attachment 8973838 [details]
Bug 1459737 - Move volume configuration to standalone function;

https://reviewboard.mozilla.org/r/242206/#review248270

> Yes. Old habits die hard, I suppose. I'll submit a minor fixup.

Actually, since this patch was about moving code, I'd rather not do the refactor here. It can be done in a follow-up.

Also, I have a hunch that we'll need to restore !root for run-task on macOS. So I am hold off changing things until we have run-task running there...

Comment 19

Last year
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf8fdc7a19db
Move run-task into taskcluster/scripts; r=dustin
https://hg.mozilla.org/integration/autoland/rev/acfbf6d8eb02
Make run-task more runnable on non-POSIX platforms; r=dustin
https://hg.mozilla.org/integration/autoland/rev/d1e1c418a26e
Teach run-task where to find Mercurial on Windows; r=dustin
https://hg.mozilla.org/integration/autoland/rev/5be219428708
Move closure to module-level function; r=dustin
https://hg.mozilla.org/integration/autoland/rev/327defec799f
Require to run on root on POSIX platforms; r=dustin
https://hg.mozilla.org/integration/autoland/rev/ea2e3306c10f
Move cache configuration to standalone function; r=dustin
https://hg.mozilla.org/integration/autoland/rev/4dd455fe0899
Move volume configuration to standalone function; r=dustin
https://hg.mozilla.org/integration/autoland/rev/3cd1fcae55de
Assert that volumes aren't used on Windows; r=dustin
Assignee

Updated

Last year
Blocks: 1459980

Comment 20

Last year
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/97fd777d726a
Add missing package dependencies to google-play-strings Dockerfile; r=nalexander CLOSED TREE
(In reply to Pulsebot from comment #20)
> Pushed by archaeopteryx@coole-files.de:
> https://hg.mozilla.org/integration/autoland/rev/97fd777d726a
> Add missing package dependencies to google-play-strings Dockerfile;
> r=nalexander CLOSED TREE

Landed on beta in order to uplift bug 1459980 at https://hg.mozilla.org/releases/mozilla-beta/rev/52f364abcc85336cf3e4fd8f928d570cc4f409a3
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.