Closed Bug 1459785 (angle-62) Opened 6 years ago Closed 6 years ago

Update ANGLE in 62 to 3396 (Chrome 67 Beta)

Categories

(Core :: Graphics, enhancement, P1)

Product:

Component:

Type:

enhancement

Priority:

P1

Severity:

normal

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla62

Tracking Flags:

Tracking

Status

firefox62

---

fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: gfx-noted)

Attachments

(3 files)

Bug 1459785 - Record merge_base_from in cherry_picks.txt. 6 years ago Kelsey Gilbert [:jgilbert] 59 bytes, text/x-review-board-request		Details
Bug 1459785 - Update ANGLE to chromium/3396. 6 years ago Kelsey Gilbert [:jgilbert] 59 bytes, text/x-review-board-request		Details
Bug 1459785 - Update test markings. 6 years ago Kelsey Gilbert [:jgilbert] 59 bytes, text/x-review-board-request		Details

Kelsey Gilbert [:jgilbert]

Assignee

Description

•

6 years ago

      No description provided.

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/242252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242252/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/242254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242254/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/245964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245964/

Comment hidden (mozreview-request)

Comment on attachment 8973883 [details]
Bug 1459785 - Record merge_base_from in cherry_picks.txt.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242252/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8973884 [details]
Bug 1459785 - Update ANGLE to chromium/3396.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242254/diff/1-2/

Comment 6

•

6 years ago

Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21af8dc00aa8
Record merge_base_from in cherry_picks.txt.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7c91a6f1b0a
Update ANGLE to chromium/3396.
https://hg.mozilla.org/integration/mozilla-inbound/rev/88675b68241a
Update test markings.

Dorel Luca [:dluca]

Comment 7

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/21af8dc00aa8
https://hg.mozilla.org/mozilla-central/rev/b7c91a6f1b0a
https://hg.mozilla.org/mozilla-central/rev/88675b68241a

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox62: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla62

Ben Kelly [:bkelly, not reviewing]

Comment 8

•

6 years ago

I got local build errors from this until I did a clobber:

make[4]: *** No rule to make target '/srv/mozilla-central/gfx/angle/checkout/src/compiler/translator/AddAndTrueToLoopCondition.cpp', needed by 'AddAndTrueToLoopCondition.o'.  Stop.

Jeff, do you think we should touch the CLOBBER file?

Flags: needinfo?(jgilbert)

Kelsey Gilbert [:jgilbert]

Assignee

Comment 9

•

6 years ago

(In reply to Ben Kelly [:bkelly] from comment #8)
> I got local build errors from this until I did a clobber:
> 
> make[4]: *** No rule to make target
> '/srv/mozilla-central/gfx/angle/checkout/src/compiler/translator/
> AddAndTrueToLoopCondition.cpp', needed by 'AddAndTrueToLoopCondition.o'. 
> Stop.
> 
> Jeff, do you think we should touch the CLOBBER file?

Weird, we shouldn't? I'll take a look.

Kelsey Gilbert [:jgilbert]

Assignee

Comment 10

•

6 years ago

> diff --git a/gfx/angle/targets/translator/moz.build b/gfx/angle/targets/translator/moz.build
> index e6890ed2de292..240b6f3ec83d5 100644
> --- a/gfx/angle/targets/translator/moz.build
> +++ b/gfx/angle/targets/translator/moz.build
>  SOURCES += [
> -    '../../checkout/src/compiler/translator/AddAndTrueToLoopCondition.cpp',
> +    '../../checkout/src/compiler/translator/tree_ops/AddAndTrueToLoopCondition.cpp',

These are the relevant diff lines. Surely this should be picked up by the build system!

Flags: needinfo?(jgilbert) → needinfo?(gps)

Gregory Szorc [:gps]

Comment 11

•

6 years ago

This does seem odd. I didn't dig into it in much detail. Probably best to file a build system bug blocking the "clobber" named bug.

Flags: needinfo?(gps)

Updated

•

6 years ago

Depends on: 1464089

Noemi Erli[:noemi_erli]

Updated

•

6 years ago

Status: RESOLVED → REOPENED

status-firefox62: fixed → ---

Resolution: FIXED → ---

Target Milestone: mozilla62 → ---

Noemi Erli[:noemi_erli]

Comment 12

•

6 years ago

Backed out 3 changesets (bug 1459785) for causing https://bugzilla.mozilla.org/show_bug.cgi?id=1464089 a=backout

https://hg.mozilla.org/mozilla-central/rev/ff8505d177b9fcba44b040ccd9b6bb709e238e84

Eric Rahm [:erahm]

Comment 13

•

6 years ago

It looks like this regressed libxul size by 250k and the subsequent backout fixed it: https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-inbound,1299711,1,2&zoom=1527026133232.3652,1527181001000,130067164.06523292,130570895.4085165

Boris Zbarsky [:bzbarsky]

Comment 14

•

6 years ago

Please do touch the CLOBBER file when you reland.  This keeps breaking my builds partway through....  :(

Nathan Froyd [:froydnj]

Comment 15

•

6 years ago

(In reply to Gregory Szorc [:gps] from comment #11)
> This does seem odd. I didn't dig into it in much detail. Probably best to
> file a build system bug blocking the "clobber" named bug.

This is bug 1421146.

Comment 16

•

6 years ago

Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8759c7d6fd48
Record merge_base_from in cherry_picks.txt.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ca4869b69ea
Update ANGLE to chromium/3396.
https://hg.mozilla.org/integration/mozilla-inbound/rev/26fde37b83e9
Update test markings.

Kelsey Gilbert [:jgilbert]

Assignee

Comment 17

•

6 years ago

Since bug 1464089 should be resolved, I've re-landed with the fix.

Eric Rahm [:erahm]

Comment 18

•

6 years ago

(In reply to Jeff Gilbert [:jgilbert] from comment #17)
> Since bug 1464089 should be resolved, I've re-landed with the fix.

This has regressed .data + .data.rel.ro by ~100k [1].

[1] https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-inbound,1686767,0,2&series=mozilla-inbound,1686771,1,2&series=mozilla-inbound,1686769,1,2&series=mozilla-inbound,1686770,1,2&series=mozilla-inbound,1686708,1,2&series=mozilla-inbound,1686772,1,2&zoom=1528168129097.701,1528168130000,-1.862645149230957e-9,4587110.686190929

Blocks: memshrink-content

Kelsey Gilbert [:jgilbert]

Assignee

Comment 19

•

6 years ago

(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #18)
> (In reply to Jeff Gilbert [:jgilbert] from comment #17)
> > Since bug 1464089 should be resolved, I've re-landed with the fix.
> 
> This has regressed .data + .data.rel.ro by ~100k [1].
> 
> [1]
> https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-inbound,
> 1686767,0,2&series=mozilla-inbound,1686771,1,2&series=mozilla-inbound,
> 1686769,1,2&series=mozilla-inbound,1686770,1,2&series=mozilla-inbound,
> 1686708,1,2&series=mozilla-inbound,1686772,1,2&zoom=1528168129097.701,
> 1528168130000,-1.862645149230957e-9,4587110.686190929

3rd party required library, there's not a ton to be done here.

UNIFIED_SOURES should win back some. That's bug 1443077.

Bogdan Tara[:bogdan_tara | bogdant]

Comment 20

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/8759c7d6fd48
https://hg.mozilla.org/mozilla-central/rev/0ca4869b69ea
https://hg.mozilla.org/mozilla-central/rev/26fde37b83e9

Status: REOPENED → RESOLVED

Closed: 6 years ago → 6 years ago

status-firefox62: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla62

Eric Rahm [:erahm]

Updated

•

6 years ago

No longer blocks: memshrink-content

Comment 21

•

6 years ago

Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01997380f76d
Update clobber file for ANGLE update; see also bug 1421146. r=me

Kartikaya Gupta (email:kats@mozilla.staktrace.com)

Comment 22

•

6 years ago

(In reply to Pulsebot from comment #21)
> Pushed by jedavis@mozilla.com:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/01997380f76d
> Update clobber file for ANGLE update; see also bug 1421146. r=me

Thank you! Too bad it's not on m-c yet or I wouldn't have wasted an hour doing a build destined to fail. Again.

Bogdan Tara[:bogdan_tara | bogdant]

Comment 23

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/01997380f76d

You need to log in before you can comment on or make changes to this bug.