Closed Bug 1459785 (angle-62) Opened 2 years ago Closed 2 years ago

Update ANGLE in 62 to 3396 (Chrome 67 Beta)

Categories

(Core :: Graphics, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: gfx-noted)

Attachments

(3 files)

No description provided.
I got local build errors from this until I did a clobber:

make[4]: *** No rule to make target '/srv/mozilla-central/gfx/angle/checkout/src/compiler/translator/AddAndTrueToLoopCondition.cpp', needed by 'AddAndTrueToLoopCondition.o'.  Stop.

Jeff, do you think we should touch the CLOBBER file?
Flags: needinfo?(jgilbert)
(In reply to Ben Kelly [:bkelly] from comment #8)
> I got local build errors from this until I did a clobber:
> 
> make[4]: *** No rule to make target
> '/srv/mozilla-central/gfx/angle/checkout/src/compiler/translator/
> AddAndTrueToLoopCondition.cpp', needed by 'AddAndTrueToLoopCondition.o'. 
> Stop.
> 
> Jeff, do you think we should touch the CLOBBER file?

Weird, we shouldn't? I'll take a look.
> diff --git a/gfx/angle/targets/translator/moz.build b/gfx/angle/targets/translator/moz.build
> index e6890ed2de292..240b6f3ec83d5 100644
> --- a/gfx/angle/targets/translator/moz.build
> +++ b/gfx/angle/targets/translator/moz.build
>  SOURCES += [
> -    '../../checkout/src/compiler/translator/AddAndTrueToLoopCondition.cpp',
> +    '../../checkout/src/compiler/translator/tree_ops/AddAndTrueToLoopCondition.cpp',

These are the relevant diff lines. Surely this should be picked up by the build system!
Flags: needinfo?(jgilbert) → needinfo?(gps)
This does seem odd. I didn't dig into it in much detail. Probably best to file a build system bug blocking the "clobber" named bug.
Flags: needinfo?(gps)
Depends on: 1464089
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla62 → ---
Please do touch the CLOBBER file when you reland.  This keeps breaking my builds partway through....  :(
(In reply to Gregory Szorc [:gps] from comment #11)
> This does seem odd. I didn't dig into it in much detail. Probably best to
> file a build system bug blocking the "clobber" named bug.

This is bug 1421146.
Since bug 1464089 should be resolved, I've re-landed with the fix.
(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #18)
> (In reply to Jeff Gilbert [:jgilbert] from comment #17)
> > Since bug 1464089 should be resolved, I've re-landed with the fix.
> 
> This has regressed .data + .data.rel.ro by ~100k [1].
> 
> [1]
> https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-inbound,
> 1686767,0,2&series=mozilla-inbound,1686771,1,2&series=mozilla-inbound,
> 1686769,1,2&series=mozilla-inbound,1686770,1,2&series=mozilla-inbound,
> 1686708,1,2&series=mozilla-inbound,1686772,1,2&zoom=1528168129097.701,
> 1528168130000,-1.862645149230957e-9,4587110.686190929

3rd party required library, there's not a ton to be done here.

UNIFIED_SOURES should win back some. That's bug 1443077.
https://hg.mozilla.org/mozilla-central/rev/8759c7d6fd48
https://hg.mozilla.org/mozilla-central/rev/0ca4869b69ea
https://hg.mozilla.org/mozilla-central/rev/26fde37b83e9
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
No longer blocks: memshrink-content
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01997380f76d
Update clobber file for ANGLE update; see also bug 1421146. r=me
(In reply to Pulsebot from comment #21)
> Pushed by jedavis@mozilla.com:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/01997380f76d
> Update clobber file for ANGLE update; see also bug 1421146. r=me

Thank you! Too bad it's not on m-c yet or I wouldn't have wasted an hour doing a build destined to fail. Again.
You need to log in before you can comment on or make changes to this bug.